Update module error message and 2 suffix allowance #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitesnowx
added
the
type.Task
iynixil
reviewed
Apr 12, 2024
| @@ -11,8 +11,8 @@ public class Module { | |||
|
|
|||
|
|
|||
| public static final String MESSAGE_CONSTRAINTS = | |||
| "Module code should contain 2-4 capital letters followed by 4 digits long and at most 1 capitalised suffix"; | |||
| public static final String VALIDATION_REGEX = "[a-zA-Z]{2,4}\\d{4}[a-zA-Z]{0,1}"; | |||
| "Module code should contain 2-4 letters followed by 4 digits long and at most 2 capitalised suffix"; | |||
There was a problem hiding this comment.
Should it be and suffix of at most 2 characters?
Comment on lines
40
to
45
| assertTrue(Module.isValidModule("CS2103")); // 2 prefix, 4 letters without 1 optional suffix | ||
| assertTrue(Module.isValidModule("CS2103T")); // 2 prefix, 4 letters with 1 optional suffix | ||
| assertTrue(Module.isValidModule("CS2103TT")); // 2 prefix, 4 letters with 2 optional suffix | ||
| assertTrue(Module.isValidModule("GEN2050")); // 3 prefix, 4 letters without 1 optional suffix | ||
| assertTrue(Module.isValidModule("GEN2050Y")); // 3 prefix, 4 letters with 1 optional suffix | ||
| assertTrue(Module.isValidModule("GESS1035")); // 4 prefix, 4 letters without 1 optional suffix |
There was a problem hiding this comment.
nit: Misleading comment 4 letters -> 4 digits?
iynixil
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plausible module:
ASP1201CH--> Increase suffix allowed to increase scope for valid inputs
Closes #235