-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The first UCLALES-SALSA results #48
Conversation
Generated notebooks for producing UCLALES-SALSA inputs and dephy outputs. The first dephy outputs are also produced and tested. On branch UCLALES-SALSA Changes to be committed: new file: notebooks/conversion/convert_comble_dephy_forcing_to_UCLALES-SALSA_forcing.ipynb new file: notebooks/conversion_output/convert_UCLALES-SALSA_output_to_dephy_format.ipynb new file: output_les/uclales-salsa/sandbox/UCLALES-SALSA_Lx25_dx100_FixN.nc new file: output_les/uclales-salsa/sandbox/UCLALES-SALSA_Lx25_dx100_FixN_def_z0.nc new file: output_les/uclales-salsa/sandbox/UCLALES-SALSA_Lx25_dx100_FixN_noice.nc
On branch UCLALES-SALSA Changes to be committed: modified: notebooks/plotting/check_les.ipynb
@TomiRaatikainen It looks like the 'FixN' and 'FixN_def_z0' files don't contain 2D information through the end of the simulation. Feel free to submit another PR that includes those fields. Thanks. |
I looked at the files and the data seemed to be there. However, the output model time varies depending on the CFL condition. In practice, the model time may exceed the target time by 1 s (the maximum time step). The plotting script (check_les.ipynb) uses condition df = df[round(df.time) == times[tt]*3600.], which means that the maximum difference is 0.5 s. The simplest fix to the problem is to change the condition to df = df[abs(round(df.time)-times[tt]*3600.)<2.]. Would this be enough for now? I can also update the data. |
@TomiRaatikainen I see, thanks for explaining. This is something we haven't thought about yet. @fridlind @floriantornow Any thoughts on how we should handle this? |
@TomiRaatikainen Yes, understood, our model does this, too. What I do is report the nearest appropriate value on the requested output time frequency, which is for all practical purposes very close as in your explanation above. If you don't mind updating your times to be precisely the requested frequency, just to simplify things on our end, that would be much appreciated, but yes, we can work with this. @floriantornow Can you please relax the check_les.ipynb rounding threshold as suggested above, in any case? Many thanks all around! |
@fridlind @twjuliano Yes, done! Thank you for the suggestion, @TomiRaatikainen ! I changed the function as suggested. |
Thanks all! @floriantornow @fridlind @TomiRaatikainen |
The first UCLALES-SALSA results for Part I can be found from output_les/uclales-salsa/sandbox/. These were calculated using notebook convert_UCLALES-SALSA_output_to_dephy_format.ipynb from notebooks/conversion_output/. Model inputs were generated using notebook convert_comble_dephy_forcing_to_UCLALES-SALSA_forcing.ipynb from notebooks/conversion/. Model inputs or the raw output data are not included.