Skip to content
This repository has been archived by the owner on Dec 12, 2020. It is now read-only.

Commit

Permalink
feat: Additional Metapackage settings
Browse files Browse the repository at this point in the history
- added IncludeSymbols=false, fixes #220
- added IncludeBuildOutput=false
- moved UsingCodeGenerationRoslynToolTargets=true to build/.props
  • Loading branch information
amis92 committed Apr 8, 2020
1 parent 1c57ad4 commit f17b102
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 10 deletions.
3 changes: 0 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,6 @@ Remove `Class1.cs` file.

Modify project file:
- Add `<Sdk>` element
- Set `IncludeBuildOutput=false`
- Add `NupkgAdditionalDependency` in ItemGroup
```xml
<!-- Duplicator/Duplicator.csproj -->
Expand All @@ -495,8 +494,6 @@ Modify project file:
<PropertyGroup>
<!-- Declare the TargetFramework(s) the same as in your Attributes package -->
<TargetFramework>netstandard1.0</TargetFramework>
<!-- We don't want any build output in package -->
<IncludeBuildOutput>false</IncludeBuildOutput>
</PropertyGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@
<PropertyGroup>
<!-- Declare the TargetFramework(s) the same as in your Attributes package -->
<TargetFrameworks>netstandard1.0;netstandard2.0</TargetFrameworks>
<!-- This project contains no files, so building can be skipped -->
<NoBuild>true</NoBuild>
<!-- Since we don't build, there'll be no build output -->
<IncludeBuildOutput>false</IncludeBuildOutput>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 0 additions & 2 deletions src/CodeGeneration.Roslyn.PluginMetapackage.Sdk/Sdk/Sdk.props
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
<!-- Announce this SDK (add *AsSdk to differentiate between using this as Sdk
and normal PackageReference/dependency usage)-->
<UsingCodeGenerationRoslynPluginMetapackageSdkAsSdk>true</UsingCodeGenerationRoslynPluginMetapackageSdkAsSdk>
<!-- Prevent running Tool targets in metapackage -->
<UsingCodeGenerationRoslynToolTargets>false</UsingCodeGenerationRoslynToolTargets>
</PropertyGroup>

<Import Project="../build/CodeGeneration.Roslyn.PluginMetapackage.Sdk.props" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@
<PropertyGroup>
<!-- Announce this SDK -->
<UsingCodeGenerationRoslynPluginMetapackageSdk>true</UsingCodeGenerationRoslynPluginMetapackageSdk>
<!-- Prevent running Tool targets in metapackage -->
<UsingCodeGenerationRoslynToolTargets>false</UsingCodeGenerationRoslynToolTargets>
<!-- Setup so that by default no build output and no symbols are packed -->
<IncludeBuildOutput>false</IncludeBuildOutput>
<IncludeSymbols>false</IncludeSymbols>
</PropertyGroup>

<!--
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

<PropertyGroup>
<TargetFramework>netstandard1.0</TargetFramework>
<IncludeBuildOutput>false</IncludeBuildOutput>
</PropertyGroup>

<ItemGroup>
Expand Down

0 comments on commit f17b102

Please sign in to comment.