Skip to content

Commit

Permalink
Merge pull request #344 from simoheinonen/php84-deprecations
Browse files Browse the repository at this point in the history
PHP 8.4 deprecations
  • Loading branch information
gregurco authored Jan 2, 2025
2 parents 363fcb2 + 3114dd4 commit b8de4c1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/DataCollector/DataCollectorSymfonyCompatibilityTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

trait DataCollectorSymfonyCompatibilityTrait
{
abstract protected function doCollect(Request $request, Response $response, \Throwable $exception = null);
abstract protected function doCollect(Request $request, Response $response, ?\Throwable $exception = null);

/**
* @param Request $request
Expand All @@ -16,7 +16,7 @@ abstract protected function doCollect(Request $request, Response $response, \Thr
*
* @return void
*/
public function collect(Request $request, Response $response, \Throwable $exception = null): void
public function collect(Request $request, Response $response, ?\Throwable $exception = null): void
{
$this->doCollect($request, $response, $exception);
}
Expand Down
2 changes: 1 addition & 1 deletion src/DataCollector/HttpDataCollector.php
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public function __construct(array $loggers, float $slowResponseTime)
/**
* {@inheritdoc}
*/
protected function doCollect(Request $request, Response $response, \Throwable $exception = null)
protected function doCollect(Request $request, Response $response, ?\Throwable $exception = null)
{
$messages = [];
foreach ($this->loggers as $logger) {
Expand Down

0 comments on commit b8de4c1

Please sign in to comment.