This fix #320

- Check if featureOfInterest and relatedFeature are not the same to avoid self-referencing in featurerelation table
52North · Sep 17, 2015 · 37833d0 · 37833d0
1 parent 5090109
commit 37833d0
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/hibernate/common/src/main/java/org/n52/sos/ds/hibernate/dao/FeatureOfInterestDAO.java b/hibernate/common/src/main/java/org/n52/sos/ds/hibernate/dao/FeatureOfInterestDAO.java
@@ -350,8 +350,10 @@ public void checkOrInsertFeatureOfInterestRelatedFeatureRelation(final FeatureOf
                 new RelatedFeatureDAO().getRelatedFeatureForOffering(offering.getIdentifier(), session);
         if (CollectionHelper.isNotEmpty(relatedFeatures)) {
             for (final RelatedFeature relatedFeature : relatedFeatures) {
-                insertFeatureOfInterestRelationShip((TFeatureOfInterest) relatedFeature.getFeatureOfInterest(),
-                        featureOfInterest, session);
+            	if (!featureOfInterest.getIdentifier().equals(relatedFeature.getFeatureOfInterest().getIdentifier())) {
+	                insertFeatureOfInterestRelationShip((TFeatureOfInterest) relatedFeature.getFeatureOfInterest(),
+	                        featureOfInterest, session);
+            	}
             }
         }
     }