Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2x-nested translation of record list fields #1

Merged
merged 1 commit into from
Jul 11, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix 2x-nested translation of record list fields
For bet365/soap#47

When using `soap:erlang2wsdl` on the referenced `.hrl`, a crash occurs
as described in the above issue. This is because the nesting of the
translated `hobbies` field is doubled up; the return value from
`erlsom_type2xsd:translateType/2` has the `MinOccurs`/`MaxOccurs`
wrapper applied twice for lists.

Ignore the list element type's `MinOccurs`/`MaxOccurs` and use the 0 and
unbounded values, for lists, respectively. This will produce the same
result as shown on https://github.com/bet365/soap/blob/6848d29d9d123c37f22b309f19de848f6309b66a/doc/generating_a_wsdl.md?plain=1#L160.

[Source .hrl](https://github.com/bet365/soap/blob/856b5c418d8d40a6b5bcbbe3fd390c6a0b8d4f18/test/soap_SUITE_data/store.hrl)
  • Loading branch information
danielfinke committed Jun 26, 2024

Verified

This commit was signed with the committer’s verified signature. The key has expired.
chraibi Mohcine Chraibi
commit 457e5ade3a4c8ffdeb84839ebf8e47f5e8638c0f
4 changes: 2 additions & 2 deletions src/erlsom_type2xsd.erl
Original file line number Diff line number Diff line change
@@ -237,8 +237,8 @@ translateType({type, _, union, Alternatives}, Tns) ->
end;

translateType({type, _, list, [Element]}, Tns) ->
TranslatedElement = translateType(Element, Tns),
{TranslatedElement, "0", "unbounded"};
{Type, _, _} = translateType(Element, Tns),
{Type, "0", "unbounded"};
translateType({type, _, record, [{atom, _, RecordType}]}, Tns) ->
{qname(atom_to_list(RecordType), Tns),
undefined, undefined};