Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid empty hash default values in analytics methods #11800

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aduth
Copy link
Member

@aduth aduth commented Jan 24, 2025

🛠 Summary of changes

Updates AnalyticsEvents method signatures to avoid assigning a default empty hash value {}, preferring nil instead to ensure values are omitted from logs.

As with #11799, this serves to reduce the size (and cost) of our logging payloads by removing values which aren't relevant for querying. It is not possible to query for an empty hash value in CloudWatch Insights.

This is also an iterative step in the migration away from errors to error_details which will involve making error_details a guaranteed return value from FormResponse#to_h.

📜 Testing Plan

Verify build passes.

changelog: Internal, Analytics, Avoid logging empty hash default values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants