Refactor responder chain logic into separate class #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that focus movement can be done by other means as well, e.g. using "Next" return key type on the keyboard.
Now demonstrates the benefit of the previous refactoring
|
Sorry I've managed to bring in and rewrite one of your commits while squashing my changes down. A branch that'll merge cleanly is at https://github.com/judev-forks/XCDFormInputAccessoryView/tree/refactor-responder-chain-2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows use of the "select adjacent" functionality by code other than the toolbar, even without necessarily having to use the inputAccessory at all.
Useful for e.g. the "Next" return key type on the keyboard. I've updated the demo app to demonstrate this.