add serialization and deserialization for BytesHash #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
reviewed
Jan 3, 2025
plonky2/src/hash/hash_types.rs
Outdated
Comment on lines
219
to
226
| let mut bytes = [0u8; N]; | ||
| for i in 0..N { | ||
| bytes[i] = seq.next_element().unwrap().unwrap(); | ||
| } |
There was a problem hiding this comment.
It think it may be best to catch deserialization errors here instead of simply panicking.
There was a problem hiding this comment.
Hi! Thanks for reviewing this!
Good call, we changed that piece of code to catch the errors. Could you look at it?
Also, there is an error when running cargo clippy, but it is not related to the code we modified. Should we fix that?
There was a problem hiding this comment.
If you don't mind, you can include it in this PR, otherwise I'll open a separate one and merge yours after :)
Thanks!
There was a problem hiding this comment.
Done! We included those changes in a separate commit
fndecroix
force-pushed
the
19-12-add-circuit-serde
branch
from
6a4617f to
fb4291a
Compare
Nashtare
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the implementation of the
serializeanddeserializetraits for theBytesHashstruct.Since the
Keccakhash function usesBytesHashas its hash type, it is now possible to serialize and deserialize proofs that use theKeccakGoldilocksConfig, like in this example