Fix build for wasm32/64-unknown-unknown without std #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
requested changes
Feb 15, 2024
| }; | ||
| #![cfg_attr(not(std), no_std)] | ||
|
|
||
| extern crate alloc; |
There was a problem hiding this comment.
We only need alloc conditionally imported here
Suggested change
| extern crate alloc; | |
| #[cfg(not(feature = "parallel"))] | |
| extern crate alloc; |
plonky2/Cargo.toml
Outdated
| serde_json = "1.0" | ||
| serde_json = { version = "1.0", default-features = false, features = ["alloc"] } |
There was a problem hiding this comment.
This actually should be moved to [dev-dependencies], it's not being used by the library (hence why it compiles fine against wasm targets), only by the fibonacci_serialization example which does require std anyway.
|
Nashtare
approved these changes
Feb 15, 2024
|
I authored #1335 and I casually noticed this PR. I think |
|
Yeah I've been telling myself this as well seeing this behavior. Will do shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1527