Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build from source on the OpenSolaris/illumos #3585

Open
IvanPizhenko opened this issue Dec 22, 2024 · 3 comments
Open

Can't build from source on the OpenSolaris/illumos #3585

IvanPizhenko opened this issue Dec 22, 2024 · 3 comments

Comments

@IvanPizhenko
Copy link

IvanPizhenko commented Dec 22, 2024

Description of the problem or steps to reproduce

Cannot build from source due to following error:

ivan@hipster:~/pro/tp/micro$ gmake
GOOS=illumos GOARCH=amd64 go generate ./runtime
CGO_ENABLED=0 go build -trimpath -ldflags "-s -w -X github.com/zyedidia/micro/v2/internal/util.Version=2.0.15-dev.90 -X github.com/zyedidia/micro/v2/internal/util.CommitHash=2898f159 -X 'github.com/zyedidia/micro/v2/internal/util.CompileDate=December 22, 2024' """ ./cmd/micro
# github.com/zyedidia/terminal
../../../go/pkg/mod/github.com/zyedidia/[email protected]/ioctl_posix.go:13:11: undefined: syscall.SYS_IOCTL
gmake: *** [Makefile:27: build-quick] Error 

Some additional information on the topic can be found here
https://stackoverflow.com/questions/73280640
Please update from "syscall" to "golang.org/x/sys/unix"

Specifications

Commit hash: 2898f15
OS: SunOS hipster 5.11 illumos-a2057e4a8d i86pc i386 i86pc
Terminal:

@IvanPizhenko IvanPizhenko changed the title Can't build from source on OpenSolaris/illumos Can't build from source on the OpenSolaris/illumos Dec 22, 2024
@JoeKar
Copy link
Collaborator

JoeKar commented Dec 22, 2024

This seems to hit the same notch as #3557.

@niten94:
Since you addressed it with zyedidia/tcell#29 it's most probably better to switch to golang.org/x/sys/unix, like go-isatty does in a newer version, which you like to bump with #3561.

@niten94
Copy link
Contributor

niten94 commented Dec 23, 2024

@niten94: Since you addressed it with zyedidia/tcell#29 it's most probably better to switch to golang.org/x/sys/unix, like go-isatty does in a newer version, which you like to bump with #3561.

I took too much time testing so I wasn't able to reply early, but I realized why the serial TTY session in my OpenBSD VM always exited when I tried switching to golang.org/x/sys/unix like in tscreen_linux.go before. Using syscall is not stable so I do think using x/sys/unix like go-isatty is better, but I will change the pull request later today.

Edit: Sorry, I realized I cannot finish the changes this early.

@niten94
Copy link
Contributor

niten94 commented Dec 24, 2024

My condition is a bit not well so there may be mistakes, but I was able to update zyedidia/tcell#29 and create zyedidia/terminal#5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants