Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the different ways of avoiding TLS requirements #342

Open
djeebus opened this issue Dec 20, 2024 · 2 comments
Open

Document the different ways of avoiding TLS requirements #342

djeebus opened this issue Dec 20, 2024 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@djeebus
Copy link
Collaborator

djeebus commented Dec 20, 2024

Scenarios that I can think of:

  • ArgoCD doesn't have a valid certificate
  • ArgoCD is listening via plaintext

It seems that recent changes have necessitate setting an additional environment variable (GRPC_ENFORCE_ALPN_ENABLED) but I'd like to make it clear when these are necessary, or simply set the env var in code when necessary based on other configuration flags.

@djeebus djeebus added the documentation Improvements or additions to documentation label Dec 20, 2024
@Greyeye
Copy link
Collaborator

Greyeye commented Dec 24, 2024

just my two cents.
most of these TLS hiccup was because of the local development.
I don't think it's ideal for us to even encourage the idea of plaintext communications in other places.

@djeebus
Copy link
Collaborator Author

djeebus commented Jan 1, 2025

That's a fair point re: plaintext, although I don't think we can control whether people have set up argocd in a way that requires it.

Invalid certificates are going to come up a lot though, either when self hosting argocd or communicating with the repo server internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants