Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: enable --show-lint-violations for sqlfluff fix #58

Open
yaozhang09 opened this issue Jan 24, 2023 · 1 comment
Open

Enhancement: enable --show-lint-violations for sqlfluff fix #58

yaozhang09 opened this issue Jan 24, 2023 · 1 comment

Comments

@yaozhang09
Copy link

Currently: unfixable violations when running sqlfluff fix causes failed check with the error [n unfixable linting violations found]
Screenshot 2023-01-23 at 4 11 17 PM

Enhancement: be able to see what rules failed in the output with the sqlfluff flag --show-lint-violations so that the dev can go into the code and manually fix. In general have an option to pass additional options/flags to the action when running fix or lint

here is sqlfluff feature:
sqlfluff/sqlfluff#3788

@yaozhang09 yaozhang09 changed the title enable --show-lint-violations for sqlfluff fix Enhancement: enable --show-lint-violations for sqlfluff fix Jan 24, 2023
@yu-iskw
Copy link
Owner

yu-iskw commented Mar 9, 2023

That sounds good. But I think supporting the feature requires a lot of efforts, because --show-lint-violatinos doesn't output as JSON or any other format to easily parse. Parsing the current format would be a bit hassle. If sqlfluff enables us to show lint violations as JSON in the future, I will consider we support the feature.

sqlfluff/sqlfluff#3788 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants