Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnamed namespaces should be removed from header files. #68

Open
LinZhihao-723 opened this issue Jan 7, 2025 · 0 comments
Open

Unnamed namespaces should be removed from header files. #68

LinZhihao-723 opened this issue Jan 7, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@LinZhihao-723
Copy link
Member

Request

The current code base has unnamed namespace used inside tpp files (for example, here). We should avoid using unnamed namespace inside hpp/tpp files.

Possible implementation

We can use xxx_internal namespace to define local helpers inside a header file, like here.
@LinZhihao-723 LinZhihao-723 added the enhancement New feature or request label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LinZhihao-723