Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add_to_nfa. #52

Open
SharafMohamed opened this issue Nov 20, 2024 · 0 comments
Open

refactor: add_to_nfa. #52

SharafMohamed opened this issue Nov 20, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@SharafMohamed
Copy link
Contributor

SharafMohamed commented Nov 20, 2024

Request

add_to_nfa should explicitly take as arguments the source and dest states.

Possible implementation

auto add_to_nfa(finite_automata::RegexNFA<NFAStateType>* nfa, NFAStateType* source, NFAStateType* dest) const -> void;

  • For void RegexASTMultiplication<NFAStateType>::add_to_nfa the implementation can also be refactored here to make better use of epsilon transitions. We can also disable the min==0 case as these are disallowed in TNFAs.
@SharafMohamed SharafMohamed added the enhancement New feature or request label Nov 20, 2024
@SharafMohamed SharafMohamed changed the title Refactor add_to_nfa. refactor: add_to_nfa. Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant