-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Message retention policy (disappearing messages) #1449
Comments
Agreed. The idiomatic approach here is admin-only for groups, both members for 1:1. |
@saulmc how do you feel about these predefined options or would you like more or less options?
|
WhatsApp's default behavior is that all members can update the Disappearing time. Link
So I think, if possible, we'd want to build in flexibility for who can manage retention — in a small group of 3 or 10 friends, "everyone" of course makes sense; in a huge channel … less so. |
I'd suggest ...
FWIW I think of like 3 broad use cases here, altho of course they're squishy:
|
My suggestion is to use a long value based on seconds, with a minimum limit (e.g., 10 seconds). We can leave it up to the integrators or clients to decide how they want to present the options to their users—such as daily, weekly, or in hours. They would then pass this value in seconds to the SDK. This approach provides flexibility to the integrators rather than imposing predefined boundaries. |
That sounds good. On the SDK level in the future we may impose some defaults just to help with ease of development but I think this makes sense for the backend. |
Would a Long value simplify things for integrators, because they'd just need to convert a timestamp instead of conform to a specific set of values? Or does it make things harder for the "out of the box" integrator who doesn't want to support anything custom? Maybe @alexrisch or @thierryskoda have a perspective on which would be easier to work with? |
I'm all good with working with seconds. It's very common with all libraries that support that kind of property. I would even say that It's more common to work with millisecond (ms). |
@nplasterer @mchenani is this metadata being set for DMs as well? |
Yep! good call out. It will be set for both but we will just need to expose it at the SDK level on dms (which we don't do for other metadata at the moment) |
We need a way to allow admins to set an expiration for messages in a group chat. Once that expiration is met messages should be deleted from all participants local database.
The text was updated successfully, but these errors were encountered: