Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any Accessory is not registered as there after a respawn with KeepInventory Gamerule enable #184

Closed
Karashok-Leo opened this issue Jan 10, 2025 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@Karashok-Leo
Copy link

  • Log: latest.log
  • Game version: 1.20.1 Fabric
  • Steps to reproduce:
    1. put on a trinket.
    2. /gamerule keepInventory true
    3. /kill
    4. the trinket was in place but not working until it was removed and put back on
@Dragon-Seeker
Copy link
Member

Can you tell me which trinket exactly was causing the issue and from what mod?

@Karashok-Leo
Copy link
Author

The issue was first discovered in a modpack, and to test it I took the minimal mod set (fabric-api, owo, accessories, tclayer, spell-power, ranged-weapon-api, jewelry, cloth-config) that could be reproduced and started it.
The issue occurs with all trinkets in Jewelry. Also in testing I found that max health would not be synchronized in time when removing a trinket that adds max health.

@Dragon-Seeker
Copy link
Member

Will investigate such coming up to see the problem

@Dragon-Seeker
Copy link
Member

@Karashok-Leo Can you try with 1.1.0-beta.22+1.21.1 and see if the bug persists at all?

@Karashok-Leo
Copy link
Author

@Karashok-Leo Can you try with 1.1.0-beta.22+1.21.1 and see if the bug persists at all?

sadly, the bug persists.

@Dragon-Seeker
Copy link
Member

Ah I see this is a 1.20.1 issue my bad, seems to be a issue with accessories itself not handling keep inventory correctly leading to issues.

@Dragon-Seeker Dragon-Seeker self-assigned this Jan 18, 2025
@Dragon-Seeker Dragon-Seeker added the bug Something isn't working label Jan 18, 2025
@Dragon-Seeker Dragon-Seeker changed the title Trinkets are temporarily invalid after rebirth Any Accessory is not registered as there after a respawn with KeepInventory Gamerule enable Jan 18, 2025
@Dragon-Seeker
Copy link
Member

Pushed an update to modrinth and curseforge that should fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants