Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.2.0 (due: end of July) #49

Closed
13 tasks done
birgits opened this issue Apr 9, 2019 · 4 comments
Closed
13 tasks done

Release v0.2.0 (due: end of July) #49

birgits opened this issue Apr 9, 2019 · 4 comments
Assignees
Milestone

Comments

@birgits
Copy link
Member

birgits commented Apr 9, 2019

The v0.2.0 will have some API changes:

  • no p_nom column in power curve csv file (@SabineHaas)
  • name parameter of wind turbine, wind farm and wind turbine cluster as optional (or remove?) (@birgits) --> same for coordinates parameter?!
  • remove power_output attribute from wind turbine, wind farm and wind turbine cluster (@birgits)
  • remove installed_power attribute (@birgits )
  • use efficiency attribute for wake_losses_to_power_curve() instead of wake_losses_model parameter (@SabineHaas)
  • remove overwrite parameter from wind_turbine.get_turbine_data_from_oedb() (@SabineHaas)
  • remove deprecation warnings (@SabineHaas and @birgits)
  • remove fetch_curve and data_source parameters from WindTurbine (@SabineHaas)
  • adapt examples (@birgits)
  • check if tests are adapted, f.e. no fetch_curve parameter (@SabineHaas)
  • csv file containing all turbine data from oedb apart from curves (@SabineHaas)
  • Check if example/modelchain_example.ipynb was merged correctly (@birgits)
  • document changes in whats new (@SabineHaas, @birgits)
@birgits birgits added this to the v0.2.0 milestone Apr 9, 2019
@uvchik
Copy link
Member

uvchik commented Apr 16, 2019

Thanks to @SabineHaas it is possible to use the windpowerlib offline but for the next major release I would suggest to restructure the API.

As there has been some communication problems in the last month I would suggest to make a breakout group at the next oemof meeting.

@birgits
Copy link
Member Author

birgits commented Apr 16, 2019

Thanks to @SabineHaas it is possible to use the windpowerlib offline but for the next major release I would suggest to restructure the API.

@uvchik can you specify this a bit more? Because if you have the csv vs hdf5 discussion in mind, we are planning to go back to csv in the next release and should therefore talk about this soon (this or the upcoming week). If it's something that can wait until the dev meeting a breakout group sounds good.

@uvchik
Copy link
Member

uvchik commented Apr 19, 2019

No, it is more about the whole data-base-file-structure. But I really appreciate the change back to csv.

@SabineHaas SabineHaas pinned this issue Jun 20, 2019
@SabineHaas SabineHaas changed the title Release v0.2.0 Release v0.2.0 (due: end of July) Jul 18, 2019
@uvchik
Copy link
Member

uvchik commented Aug 19, 2019

PR #62 includes my ideas from above.

@birgits birgits closed this as completed Sep 9, 2019
@SabineHaas SabineHaas unpinned this issue Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants