New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect type hints on memoize `key` #958

Open

ntjess opened this issue Jan 5, 2025 · 0 comments · May be fixed by #959

Contributor

ntjess commented Jan 5, 2025 •

edited

Loading

Pretty straightforward -- the key should return something hashable, not the same return type as its memoized function. Occurrences of:

key: Callable[P, R]

Should be

# Earlier
# from typing import Hashable

key: Callable[P, Hashable]

ntjess added a commit to ntjess/solara that referenced this issue


          Fixes incorrect type hints on memoize key widgetti#958

f6821c2

ntjess linked a pull request

that will close this issue

fix: incorrect type hints on memoize key #958 #959

Open

4 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment