-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.42.0 - Minor Improvements #4479
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/cypress |
…adrian/5-42-0-minor-feats
/cypress |
Cypress E2E tests have been initiated (for more information, click here). ✨ |
/cypress |
Cypress E2E tests have been initiated (for more information, click here). ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
1. Example Extensions - Introduced Optional
extension.json
From now on, upon downloading an example extension from our webiny-examples repo, the
webiny extension
command will also try to look for the newly introducedextension.json
file, which is basically a file that can contain additional information about the extension. The file is optional, and can be placed by theextensions
folder when creating an example extension, for example page-builder/custom-page-elements.Note
The TS interface that the
extension.json
adheres to can be found here.2. Custom Next Steps / Additional Notes via
extension.json
Via the
nextSteps
andadditionalNotes
properties inextension.json
file, we can now define additional messages that will be shown to the user once the extension has been downloaded / linked.For example, before, when downloading the Smart SEO extension, users would see the following:
Now, because I've defined additional Next Steps and Additional Notes messages via
extension.json
, users will see them at the end of the download / link process:3. Link To the Extensions Article In
extensions.ts
/extensions.tsx
FilesIn all
extensions.ts
andExtensions.tsx
files, I've added the comment:We had a case where user ended up in one of these files, and was confused what this file is for. With the link in plae, users will be able to quickly learn what this file really is.
4. Removed
apps/api/graphql/src/types.ts
FileWith 5.42.0, newly created Webiny projects will no longer contain the
apps/api/graphql/src/types.ts
file.This is basically because the file only contained one type, and that was the
Context
interface (example). The interface is no longer needed, because it's actually exported from the@webiny/api-serverless-cms
package and can be imported from there.How Has This Been Tested?
Manually.
Documentation
Not needed.