Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA(post-merge): Add config param to enable/disable wallet signature #43

Open
web4er opened this issue Jul 28, 2023 · 34 comments
Open

QA(post-merge): Add config param to enable/disable wallet signature #43

web4er opened this issue Jul 28, 2023 · 34 comments
Labels
Time: <1 Hour

Comments

@web4er
Copy link
Owner

web4er commented Jul 28, 2023

For testing, I will change the config option register-wallet-with-verification in file .github/ubiquibot-config.yml in this fork's development branch.
@web4er
Copy link
Owner Author

web4er commented Jul 28, 2023

Current value: register-wallet-with-verification: false

@web4er
Copy link
Owner Author

web4er commented Jul 28, 2023

should accept wallet command without signature

@web4er
Copy link
Owner Author

web4er commented Jul 28, 2023

/wallet 0x1F9FCc0E84dc2094499b848AE37Cd6a51db03Ff2

@web4er-ubiquibot
Copy link

Updated the wallet address for @web4er successfully! Your new address: 0x1F9FCc0E84dc2094499b848AE37Cd6a51db03Ff2

@web4er
Copy link
Owner Author

web4er commented Jul 28, 2023 •
edited
Loading

setting register-wallet-with-verification: true

@web4er
Copy link
Owner Author

web4er commented Jul 28, 2023

/wallet 0x1F9FCc0E84dc2094499b848AE37Cd6a51db03Ff2

@web4er-ubiquibot
Copy link

Skipping to register the wallet address because you have not provided a valid SIGNATURE_HASH.
Use etherscan to sign the message DevPool and register your wallet by appending the signature hash.

Usage:
/wallet <WALLET_ADDRESS | ENS_NAME> <SIGNATURE_HASH>

Example:
/wallet 0x0000000000000000000000000000000000000000 0x0830f316c982a7fd4ff050c8fdc1212a8fd92f6bb42b2337b839f2b4e156f05a359ef8f4acd0b57cdedec7874a865ee07076ab2c81dc9f9de28ced55228587f81c

@web4er
Copy link
Owner Author

web4er commented Jul 28, 2023

/wallet

@web4er-ubiquibot
Copy link

Please include your wallet or ENS address.
usage: /wallet 0x0000000000000000000000000000000000000000 0x0830f316c982a7fd4ff050c8fdc1212a8fd92f6bb42b2337b839f2b4e156f05a359ef8f4acd0b57cdedec7874a865ee07076ab2c81dc9f9de28ced55228587f81c

@web4er
Copy link
Owner Author

web4er commented Jul 28, 2023

/assign

@web4er-ubiquibot
Copy link

Deadline Fri, 28 Jul 2023 12:07:17 GMT
Registered Wallet Please set your wallet address to use `/wallet 0x4FDE...BA18`
Payment Multiplier 1.00
Multiplier Reason undefined
Total Bounty Permit generation skipped since price label is not set
Tips:
  • Use /wallet 0x4FDE...BA18 if you want to update your registered payment wallet address @user.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

    @web4er
    Copy link
    Owner Author

    web4er commented Jul 28, 2023

    /unassign

    @web4er-ubiquibot
    Copy link

    You have been unassigned from the bounty @web4er

    @web4er
    Copy link
    Owner Author

    web4er commented Jul 28, 2023

    /help

    @web4er-ubiquibot
    Copy link

    Available commands

    - /assign: Assign the origin sender to the issue automatically.
- /unassign: Unassign the origin sender from the issue automatically.
- /help: List all available commands.
- /multiplier: Set the bounty payout multiplier for a specific contributor, and provide the reason for why. 
  example usage: "/wallet @user 0.5 'Multiplier reason'"
- /allow: Set access control. (Admin Only)
- /wallet: <WALLET_ADDRESS | ENS_NAME> <SIGNATURE_HASH>: Register the hunter's wallet address. 
  Your message to sign is: DevPool
  You can generate SIGNATURE_HASH at https://etherscan.io/verifiedSignatures
  ex1: /wallet 0x0000000000000000000000000000000000000000 0xe2a3e34a63f3def2c29605de82225b79e1398190b542be917ef88a8e93ff9dc91bdc3ef9b12ed711550f6d2cbbb50671aa3f14a665b709ec391f3e603d0899a41b
  ex2: /wallet vitalik.eth 0x75329f883590507e581cd6dfca62680b6cd12e1f1665db8097f9e642ed70025146b5cf9f777dde90c4a9cbd41500a6bf76bc394fd0b0cae2aab09f7a6f30e3b31b

    @web4er
    Copy link
    Owner Author

    web4er commented Jul 28, 2023

    /allow set-multiplier @web4er true

    @web4er-ubiquibot
    Copy link

    Updated access for @web4er successfully! Access: multiplier for "web4er/ubiquibot"

    @web4er
    Copy link
    Owner Author

    web4er commented Jul 28, 2023

    /multiplier 0.7 @web4er "testing"

    @web4er-ubiquibot
    Copy link

    Successfully changed the payout multiplier for @web4er to 0.7. The reason provided is "testing ".

    @web4er
    Copy link
    Owner Author

    web4er commented Jul 28, 2023

    /assign

    @web4er-ubiquibot
    Copy link

    Deadline Fri, 28 Jul 2023 12:13:29 GMT
    Registered Wallet Please set your wallet address to use `/wallet 0x4FDE...BA18`
    Payment Multiplier 1.00
    Multiplier Reason undefined
    Total Bounty Permit generation skipped since price label is not set
    Tips:
    • Use /wallet 0x4FDE...BA18 if you want to update your registered payment wallet address @user.
    • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
    • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

      @web4er
      Copy link
      Owner Author

      web4er commented Jul 28, 2023

      /unassign

      1 similar comment
      @web4er
      Copy link
      Owner Author

      web4er commented Jul 28, 2023

      /unassign

      @web4er-ubiquibot
      Copy link

      You have been unassigned from the bounty @web4er

      @web4er
      Copy link
      Owner Author

      web4er commented Jul 28, 2023

      /assign

      @web4er-ubiquibot
      Copy link

      Deadline Fri, 28 Jul 2023 12:16:21 GMT
      Registered Wallet Please set your wallet address to use `/wallet 0x4FDE...BA18`
      Payment Multiplier 1.00
      Multiplier Reason undefined
      Total Bounty Permit generation skipped since price label is not set
      Tips:
      • Use /wallet 0x4FDE...BA18 if you want to update your registered payment wallet address @user.
      • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
      • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

        @web4er
        Copy link
        Owner Author

        web4er commented Jul 28, 2023

        /wallet 0x1F9FCc0E84dc2094499b848AE37Cd6a51db03Ff2

        @web4er-ubiquibot
        Copy link

        Skipping to register the wallet address because you have not provided a valid SIGNATURE_HASH.
        Use etherscan to sign the message DevPool and register your wallet by appending the signature hash.

        Usage:
        /wallet <WALLET_ADDRESS | ENS_NAME> <SIGNATURE_HASH>

        Example:
        /wallet 0x0000000000000000000000000000000000000000 0x0830f316c982a7fd4ff050c8fdc1212a8fd92f6bb42b2337b839f2b4e156f05a359ef8f4acd0b57cdedec7874a865ee07076ab2c81dc9f9de28ced55228587f81c

        @web4er
        Copy link
        Owner Author

        web4er commented Jul 28, 2023

        /wallet 0x1F9FCc0E84dc2094499b848AE37Cd6a51db03Ff2 0x02aa024ce04bfe53648d410cee03a046c54e6ec558b26e376b207cf36c8685404e00e7e2ccb0ba5114f1b890c90881f016f628efbb21c930db789c157690e58c1b

        @web4er-ubiquibot
        Copy link

        Updated the wallet address for @web4er successfully! Your new address: 0x1F9FCc0E84dc2094499b848AE37Cd6a51db03Ff2

        @web4er
        Copy link
        Owner Author

        web4er commented Jul 30, 2023

        /assign

        @web4er-ubiquibot
        Copy link

        Skipping /assign since the issue is already assigned

        @web4er
        Copy link
        Owner Author

        web4er commented Jul 30, 2023

        /unassign

        @web4er-ubiquibot
        Copy link

        You have been unassigned from the bounty @web4er

        Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
        Assignees
        No one assigned
        Labels
        Time: <1 Hour
        Projects
        None yet
        Milestone
        No milestone
        Development

        No branches or pull requests
        1 participant
        @web4er