From 7b4d294b529c593f995fe0a83964dc25eccea219 Mon Sep 17 00:00:00 2001
From: shinhong_park <shp7724@snu.ac.kr>
Date: Sat, 17 Dec 2022 23:51:40 +0900
Subject: [PATCH] Add app_version parameter to fastlane (#196)

* add app_version parameter

* fix increment_version_number
---
 SNUTT-2022/Gemfile.lock        |  2 ++
 SNUTT-2022/fastlane/Fastfile   | 11 ++++++-----
 SNUTT-2022/fastlane/Pluginfile |  1 +
 3 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/SNUTT-2022/Gemfile.lock b/SNUTT-2022/Gemfile.lock
index 117a2b52..ba15873e 100644
--- a/SNUTT-2022/Gemfile.lock
+++ b/SNUTT-2022/Gemfile.lock
@@ -116,6 +116,7 @@ GEM
       fastlane (>= 2.148.1)
       rbnacl
       sshkey
+    fastlane-plugin-versioning (0.5.1)
     ffi (1.15.5)
     gh_inspector (1.1.3)
     google-apis-androidpublisher_v3 (0.29.0)
@@ -230,6 +231,7 @@ DEPENDENCIES
   fastlane
   fastlane-plugin-badge
   fastlane-plugin-github_action
+  fastlane-plugin-versioning
 
 BUNDLED WITH
    2.3.11
diff --git a/SNUTT-2022/fastlane/Fastfile b/SNUTT-2022/fastlane/Fastfile
index d8a678cd..bd319fc7 100644
--- a/SNUTT-2022/fastlane/Fastfile
+++ b/SNUTT-2022/fastlane/Fastfile
@@ -38,8 +38,8 @@ platform :ios do
       if BUILD_CONFIGURATION == "Debug"
         add_badge(dark: true)
       end
-      increment_version_number(version_number: VERSION_NUMBER)
-      increment_build_number(build_number: BUILD_NUMBER)
+      increment_version_number_in_xcodeproj(version_number: VERSION_NUMBER)
+      increment_build_number_in_xcodeproj(build_number: BUILD_NUMBER)
       build_app(scheme: APP_NAME, 
       configuration: BUILD_CONFIGURATION,
       output_directory: "./archive",
@@ -50,7 +50,7 @@ platform :ios do
         issuer_id: APP_STORE_CONNECT_KEY_ISSUER,
         key_content: KEY_CONTENT,
         )
-      upload_to_testflight
+      upload_to_testflight(app_version: VERSION_NUMBER)
       slack(
         message: "App successfully uploaded to Testflight 🎉",
         channel: "#team-snutt-deploy",
@@ -77,8 +77,8 @@ platform :ios do
     begin
       setup_ci
       certificates_distribution
-      increment_version_number(version_number: VERSION_NUMBER)
-      increment_build_number(build_number: BUILD_NUMBER)
+      increment_version_number_in_xcodeproj(version_number: VERSION_NUMBER)
+      increment_build_number_in_xcodeproj(build_number: BUILD_NUMBER)
       build_app(scheme: APP_NAME, 
         configuration: BUILD_CONFIGURATION,
         output_directory: "./archive",
@@ -93,6 +93,7 @@ platform :ios do
       release = get_github_release(url: "wafflestudio/snutt-ios", version: GIT_TAG_NAME)
       upload_to_app_store(
           force: true,
+          app_version: VERSION_NUMBER,
           skip_screenshots: true,
           submit_for_review: true,
           automatic_release: false,
diff --git a/SNUTT-2022/fastlane/Pluginfile b/SNUTT-2022/fastlane/Pluginfile
index 62d52859..540567da 100644
--- a/SNUTT-2022/fastlane/Pluginfile
+++ b/SNUTT-2022/fastlane/Pluginfile
@@ -4,3 +4,4 @@
 
 gem 'fastlane-plugin-github_action'
 gem 'fastlane-plugin-badge'
+gem 'fastlane-plugin-versioning'