-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Motivate why bacv:usesService term is needed #385
Comments
The TD spec defines a vocabulary for WoT operations:
BACnet defines a vocabulary for BACnet services:
So they are two different vocabularies, even if they contain a few very similar terms. Do you have a suggestion how this could be better presented in the document? |
I don't have a good suggestion, but IF TD op values can "always" match the BACnet services I would think we don't need the term The BACnet binding document could create a table instead like
EDIT: I see that this mapping exists already, https://w3c.github.io/wot-binding-templates/bindings/protocols/bacnet/#default-mappings |
I think it's just a coincidence that some of the terms from the different vocabularies are almost the same. We shouldn't try to optimize anything here. Suggestions for making it clearer in the document that there are two different vocabularies are welcome. Otherwise I would suggest closing this issue. |
The reasons for introducing
We could add a blurb at the beginning of the section https://w3c.github.io/wot-binding-templates/bindings/protocols/bacnet/#default-mappings, something like:
Or we can also close the issue. |
The term should be definitely kept. Otherwise, we would need to write something like "Change the capitalization of the first letter and get the BACnet term" which is quite weird in my point of view. |
I am fine with closing. What I was trying to say is that a TD does not necessarily need to contain for example "bacv:usesService": "ReadProperty" IF it can be always added/mapped according to To me, it is a bit like in the HTTP binding, where |
Exactly. If the default mapping suits your needs, you can omit This also helps for avoiding repeating the form when the only difference is So, shall we close or add this blurb? |
I am fine either way. What do others think? |
The term
bacv:usesService
seems to be easily linked to theop
value (at least according to the examples).e.g.,
"op": [ "readproperty" ]
-->"bacv:usesService": "ReadProperty"
Since I am pretty sure that there is a reason why we need the additional term
bacv:usesService
I think it makes sense to motivate the reason in the binding document.The text was updated successfully, but these errors were encountered: