Skip to content
This repository has been archived by the owner on Oct 16, 2022. It is now read-only.

πŸ› DockerHub README renders two logos #12

Open
vsnthdev opened this issue Apr 15, 2022 · 0 comments
Open

πŸ› DockerHub README renders two logos #12

vsnthdev opened this issue Apr 15, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@vsnthdev
Copy link
Owner

πŸ› What happens

The DockerHub READMEs don't support different logos for light & dark modes, so both the logos are rendered in DockerHub READMEs unlike GitHub πŸ‘‡

Snip

βœ… What should happen

The README for both @alpa/api and @alpa/app should only contain the light version of logo on DockerHub πŸ‘‡

Snip

♻️ Steps to reproduce

Re-execute the README syncing CD/CD pipeline and visit DockerHub pages for @alpa/api and @alpa/app.

🧐 My Observations

A separate context variable should be taken from command line args when building docs which would disable the dark version of the logo in the README.md.

This argument (--dockerhub for example) should be used right before the README syncing CD/CD pipeline is triggered.

@vsnthdev vsnthdev added the bug Something isn't working label Apr 15, 2022
@vsnthdev vsnthdev self-assigned this Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant