-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pick some packages from other vpm repository #21
Comments
You are welcome to fork and modify these scripts to fit your needs! |
@momo-the-monster, Could you answer #11? This repository has no license so I cannot know which license will be applied to new features I'll write. |
@anatawa12 That was one of the ideas i had for my issue #20 but in the end what i did is integrate the projects as github projects and only handled a specific use case for what i called "deprecated project ids". Would that help you ? |
Many of vpm repository author creates vpm repository without this action so I think it's much better for compatibility to use vpm repository. In addition, I think this action is not good for picking third-party because this action increases download count when vpm repository creates. |
So you would definitly need a way to integrate within this action to integrate packages from another vpm repository. Any idea on how you would describe such thing in the source.json ? I thought about having an "vpmRepos" entry as following: {
"vpmRepos": [
"https://spokeek.github.io/vpm-repository/index.json",
{
"source": "https://vpm.anatawa12.com/vpm.json",
"ignorePackages": [
"com.anatawa12.continuous-avatar-uploader"
]
}
]
} or would you rather do the opposite and list the needed packages ? |
I think listing picking packages instead of listing ignored is much better since vpm repository author can add any package any time. {
"vpmPackages": {
"nadena.dev.ndmf": "https://vpm.nadena.dev/vpm.json",
"com.anatawa12.continuous-avatar-uploader": ["https://vpm.anatawa12.com/vpm.json"],
"com.anatawa12.avatar-optimizer": {
"includePrereleases": true,
"versionRange": ">=1.0.0, <2.0.0"
"sources": ["https://vpm.anatawa12.com/vpm.json"]
}
}
} {
"vpmRepos": [
{
"source": "https://vpm.anatawa12.com/vpm.json",
"packages": [
"com.anatawa12.continuous-avatar-uploader"
]
}
]
} {
"vpmRepositories": {
"https://vpm.anatawa12.com/vpm.json": {
"packages": ["com.anatawa12.continuous-avatar-uploader"]
}
}
} I think the first is the best format for configuration since
|
No yet. I can do tomorrow but not started yet. |
It's up to you, If you want to do it, please describe it on that issue or on a PR, i'll look at it and my use it myself (wanted to use _bd vpm repo in that way) |
I'll implement this suggestion tomorrow. |
I think it's better to pick some packages from other vpm listing.
In some vpm listing, this generator is not used (since this is not published in early days) so I think it's better to have way to pick package from other vpm listing instead of adding repository.
The text was updated successfully, but these errors were encountered: