From dd686e336b405db36b23bf776c8702248ef5f8c3 Mon Sep 17 00:00:00 2001 From: Sumit Vij Date: Sat, 11 Jan 2025 01:21:08 +0000 Subject: [PATCH] Fix formatting and test case Signed-off-by: Sumit Vij --- tests/lora/test_ultravox.py | 4 ++-- vllm/lora/models.py | 1 - vllm/model_executor/models/ultravox.py | 1 - 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/lora/test_ultravox.py b/tests/lora/test_ultravox.py index 206599f9940b7..463c289fa3f8b 100644 --- a/tests/lora/test_ultravox.py +++ b/tests/lora/test_ultravox.py @@ -16,7 +16,7 @@ VLLM_PLACEHOLDER = "<|reserved_special_token_0|>" -PROMPT = "Tell me about a silly chess move in 20 words" +PROMPT = "Tell me about a Fool's mate move in 20 words. Provide the moves!" def llama3_1_8b_chess_lora_path(): @@ -60,7 +60,7 @@ def _get_prompt(audio_count, question, placeholder, model_name) -> str: add_generation_prompt=True) -def test_ultravox_lora(vllm_runner, ): +def test_ultravox_lora(vllm_runner): llama3_1_8b_chess_lora = llama3_1_8b_chess_lora_path() with TemporaryDirectory() as temp_ultravox_lora_dir: llama3_1_8b_ultravox_chess_lora = mk_llama3_1_8b_ultravox_chess_lora( diff --git a/vllm/lora/models.py b/vllm/lora/models.py index 1226a275f84a9..5b7225bdc8f37 100644 --- a/vllm/lora/models.py +++ b/vllm/lora/models.py @@ -407,7 +407,6 @@ def activate_adapter( module_lora.bias) else: module.reset_lora(index) - return True def _deactivate_adapter(self, lora_id: int): diff --git a/vllm/model_executor/models/ultravox.py b/vllm/model_executor/models/ultravox.py index b28951fef6a9d..464651a6a2647 100644 --- a/vllm/model_executor/models/ultravox.py +++ b/vllm/model_executor/models/ultravox.py @@ -346,7 +346,6 @@ def forward( return hidden_states - @MULTIMODAL_REGISTRY.register_processor(UltravoxMultiModalProcessor, info=UltravoxProcessingInfo, dummy_inputs=UltravoxDummyInputsBuilder