Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] support to run partially 2:4 model with CompressedTensors24 scheme #11889

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jiangjiadi
Copy link
Contributor

@jiangjiadi jiangjiadi commented Jan 9, 2025

After using llmcompressor to create a partially 2:4 sparse FP8 quantized model (where the MLP layers are sparse, but the attention layers are not), I tested its speed and found that the inference speed of this model did not differ from that of a regular FP8 quantized model. Further investigation revealed that although the MLP layers are 2:4 sparse, the get_scheme function in the CompressedTensorsConfig of the code repository does not handle this partially sparse model appropriately, causing the MLP layers to not utilize the CompressedTensors24 scheme.
Before:
image
Fixed:
image

FIX vllm-project/llm-compressor#1037

Tested_model:

  • original qwen2.5-3B
  • fp8 quantized qwen2.5-3B
  • fully 2:4 sparse fp8 quantized qwen2.5-3B
  • partially 2:4 sparse fp8 quantized qwen2.5-3B

Copy link

github-actions bot commented Jan 9, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@jeejeelee jeejeelee requested a review from mgoin January 9, 2025 08:26
@mgoin
Copy link
Member

mgoin commented Jan 9, 2025

cc @dsikka @rahul-tuli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does llmcompressor support hybrid sparsity?
2 participants