suggested fix for issue #74564 #74565
Open
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
himself65
reviewed
Jan 6, 2025
There was a problem hiding this comment.
I think you just need pathToFileURL(path) here?
There was a problem hiding this comment.
I had forgotten to add the require for pathToFile which I fixed just now.
Regarding your comment, I'm not sure I understand what you suggest. I mean I'm not sure to what line of the code your comment is referring. Do you mean moving pathToFileURL into the interopDefault function?
Do you mean using pathToFileUrl without also using "require.resolve"?
- the
importPluginfunction gets the plugin value (and the project root path) - the
pluginvalue is an array, where the first value is the mdx plugin name (the package name) as a string and the second value (which is optional) contains the plugin options (which need to be serializable) - using
require.resolvewe get the path of the plugin (package) by passing the name and project root path - then comes my change which fixes the path we get from previous step and turns it into a windows file URL using
pathToFileURL(if the platform is windows) - now the import function is not throwing an error anymore (on windows) because the value we pass to import is now a valid file:// URL and not a string like 'c:/PATH_TO_ESM_PACKAGE'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74564
The idea for the fix is from fbf9e12#diff-907b7be0cfc75bd37773e5ebc38d1deffa40861b8ac1cde92e4992e284a1ee59R1221 I use the same nodejs pathToFileURL (https://github.com/vercel/next.js/blob/canary/packages/next/src/lib/find-config.ts#L74)