Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE - Inspect Page] Don't highlight selecting elements in "inspect-document" section after clicking on the outside bbox #96

Open
nikitakovaliov92 opened this issue Jun 10, 2020 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@nikitakovaliov92
Copy link

nikitakovaliov92 commented Jun 10, 2020

7.18.8-t01-fail-a.pdf

  1. Open inspect page with attached PDF
  2. Select element in "inspect-document" section
  3. Click outside of bbox

Actual result: Element still highlighted
Expected result: No element highlighted

@yuliya-ivaniukovich yuliya-ivaniukovich added this to the 0.2.0 milestone Jun 10, 2020
@yuliya-ivaniukovich yuliya-ivaniukovich added the enhancement New feature or request label Jun 10, 2020
@Resip10
Copy link
Contributor

Resip10 commented Jun 10, 2020

For now bbox selection cancels on click only on document area. Bbox from the above file fill full page size and it's impossible to click on anywhere except bbox itself.
I can offer two decisions how cancel selection:

  • on second click on selected bbox
  • click on empty area outside of pdf document

@yuliya-ivaniukovich
Copy link
Contributor

This should be easier when we rewrite bboxes to DIV's so let's postpone and make this after Inspect page is correctly implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants