Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE]: summary visual improvements #41

Open
yuliya-ivaniukovich opened this issue May 26, 2020 · 0 comments
Open

[FE]: summary visual improvements #41

yuliya-ivaniukovich opened this issue May 26, 2020 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@yuliya-ivaniukovich
Copy link
Contributor

yuliya-ivaniukovich commented May 26, 2020

At the moment when we validate a file with large number of checks and only small amount of them failed we have the following minor issues:

  1. Error sector in Pie chart is not visible at all
  2. Success sector tooltip says 100% (our total displays 99%)
  3. Success checks number in legend is formatted poorly (no thousands separator)

Tech notes:
[ ] instead of passing absolute numbers to chart let's calculate percents ourselves so that neither sector could be 100% if other values are not 0 (cover this calculations with unit tests)
[ ] let's customize chart tooltip as following:

99.99% passed
(1,700,000 checks)

0.01% errors
(15 checks)

Pie center still should display rounded(floored) 99% in case above.

PS: precision of 2 decimals is just an example, we can adjust it so that minimal sector was displayed in Google Chart.

@yuliya-ivaniukovich yuliya-ivaniukovich added the enhancement New feature or request label May 26, 2020
@yuliya-ivaniukovich yuliya-ivaniukovich added this to the 0.2.0 milestone May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant