Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frequency filter settings above 5% fail filter #2192

Open
stolpeo opened this issue Jan 13, 2025 · 2 comments
Open

frequency filter settings above 5% fail filter #2192

stolpeo opened this issue Jan 13, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@stolpeo
Copy link
Contributor

stolpeo commented Jan 13, 2025

Describe the bug
The frequency filter setting for gnomad exomes/genomes, 1000 genomes and exac make the filter fail (or more precisely nothing happens when the user clicks the filter button) when the settings is above 0.05 (5%).

@stolpeo stolpeo added the bug Something isn't working label Jan 13, 2025
@stolpeo
Copy link
Contributor Author

stolpeo commented Jan 13, 2025

RCA

The JSON scheme only allows for a range of 0-0.05. This makes the submission fail. In production, the server returns a simple 500 error without stating any reason. The frontend simply does not do anything when the user hits the filter button.

@stolpeo
Copy link
Contributor Author

stolpeo commented Jan 13, 2025

Solution

The current state is obviously more than confusing for the user.

  1. The frontend apparently does not display errors that are caused by the JSON scheme validator and simply fails.
    1. Check if that is true for all JSON scheme validator errors or only this one
    2. Correct that the user gets a proper error message displayed
    3. Decide whether the input check should already happen during input.
  2. Why is there a maximum of 0.05? Could that be extended to accept values from 0-1 (basically the whole possible range)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant