Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor replacing go-llsqlite/crawshaw with mattn/go-sqlite3 #482

Open
evrins opened this issue May 23, 2024 · 0 comments
Open

refactor replacing go-llsqlite/crawshaw with mattn/go-sqlite3 #482

evrins opened this issue May 23, 2024 · 0 comments

Comments

@evrins
Copy link
Collaborator

evrins commented May 23, 2024

tried replacing go-llsqlite/crawshaw with mattn/go-sqlite3
have to add compile tag nosqlite to disable go-llsqlite/crawshaw in torrent lib to make it compile or duplicate symbol erorr may occur

go-llsqlite/crawshaw in torrent is used for piece completion storage, since we have implemented , it is ok to disable it.

this change will increase binary size by 2 Mib on my mac

mattn/go-sqlite3 is database/sql compatible, we can use with pgx to reduce duplicate code

with SetMaxOpenConns(1) we can remove locked in every function call and will not trigger database is locked error

code is on branch refactor/migrate_to_mattn_go-sqlite3

@varbhat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant