-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update UI to indicate when a plugin attached to an entrypoint is out-of-date and provide a mechanism to sync to the latest version of plugins. #678
Open
keithmanville
wants to merge
16
commits into
dev
Choose a base branch
from
plugin-files-as-dependent-children-of-plugins
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
keithmanville
commented
Dec 12, 2024
made some modifications to use the Plugin -> PluginFiles relationship. This simplifies service layer code and I was able to remove some repeated queries. |
keithmanville
commented
Dec 13, 2024
keithmanville
changed the title
feat: split entry_point_plugin_files table into two linking tables
We want the UI to indicate when a plugin attached to an entrypoint is out-of-date and provide a mechanism to sync to the latest version of plugins.
Dec 13, 2024
keithmanville
changed the title
We want the UI to indicate when a plugin attached to an entrypoint is out-of-date and provide a mechanism to sync to the latest version of plugins.
Update UI to indicate when a plugin attached to an entrypoint is out-of-date and provide a mechanism to sync to the latest version of plugins.
Dec 13, 2024
This update takes the entry_point_plugin_files table and splits it down into 2 separate linking tables, plugin_plugin_files and entry_point_plugins. This change allows us to treat the plugin files as entirely coupled to the plugins namespace as a container, instead of their snapshotted history being tied to updates in the entrypoint.
keithmanville
force-pushed
the
plugin-files-as-dependent-children-of-plugins
branch
from
December 24, 2024 13:41
d408837
to
cb14c2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want the UI to indicate when a plugin attached to an entrypoint is out-of-date and provide a mechanism to sync to the latest version of plugins.
This update takes the entry_point_plugin_files table and splits it down into 2 separate linking tables, plugin_plugin_files and entry_point_plugins. This change allows us to treat the plugin files as entirely coupled to the plugins namespace as a container, instead of their snapshotted history being tied to updates in the entrypoint.
In the entrypoint table and edit form, plugins should be labeled as outdated if it isn't the latestSnapshot. Beside each outdated plugin should be a "sync to latest plugin" button that should update the plugin to the latest snapshot. This is available in the entrypoint edit form and the assign plugins dialog in the entrypoints table.