Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularity: Extract tasks into separate repos #3

Closed
15 of 17 tasks
backflip opened this issue Nov 21, 2017 · 4 comments
Closed
15 of 17 tasks

Modularity: Extract tasks into separate repos #3

backflip opened this issue Nov 21, 2017 · 4 comments

Comments

@backflip
Copy link

backflip commented Nov 21, 2017

Tasks

Examples:

Criteria:

  • Exporting task factory
    • Taking options overwriting defaults as argument. Defaults for a "standard" gulp task:
    • Exposing options for everything configurable. Setting plugin options to null should disable the corresponding step
    • Returning a gulp stream in case of "standard" gulp tasks. Most probably returning a promise otherwise since we don't want to deal with callbacks.
    • Using gulp-plumber to prevent stream from unpiping, adding .on('error', err => config.logger.error(err, dev)) to every step possibly throwing.
  • Using gulp 4 (if using gulp). Probably not having an effect on "standard gulp tasks since they mostly use gulp.src and gulp.dest which should not break anything for us
  • Not using gulp-util which will be deprecated. Rather rely on the underlying modules (plugin-error, fancy-log, chalk, minimist etc.
  • Documenting usage and options in README.md
  • Adding tests
@drowka
Copy link
Member

drowka commented Jan 2, 2018

@backflip FYI I'll try to tackle CSS or SVG Sprite as I currently have some downtime. I'm not in the Unic group, but maybe an IT ticket can solve that :)

@Wymowny
Copy link
Member

Wymowny commented Jan 4, 2018

FYI; I'm in the middle of css:lint task

@backflip
Copy link
Author

backflip commented Feb 6, 2018

Thanks a bunch, @drowka and @Wymowny, I have added your packages to https://github.com/unic/estatico-lerna/tree/master/packages

@backflip
Copy link
Author

backflip commented Feb 8, 2018

Moved to unic/estatico-nou#2

@backflip backflip closed this as completed Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants