Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eff_tf_cryo needs to be an input but keeping the existing default values #1431

Open
jonmaddock opened this issue Oct 20, 2021 · 2 comments · May be fixed by #3492
Open

eff_tf_cryo needs to be an input but keeping the existing default values #1431

jonmaddock opened this issue Oct 20, 2021 · 2 comments · May be fixed by #3492
Assignees
@jmorris-uk

Comments

@jonmaddock
Copy link
Contributor

In GitLab by @cjwgriesel on Oct 20, 2021, 14:40

in plant_power.f90
real(8) :: eff_tf_cryo
!! TF cryoplant efficiency (compared to pefect Carnot cycle).
!! Using -1 set the default value depending on magnet technology:
!!
!! - i_tf_sup = 1 : SC magnet, eff_tf_cryo = 0.13 (ITER design)
!! - i_tf_sup = 2 : Cryo-aluminium, eff_tf_cryo = 0.4

eff_tf_cryo needs to have the option of being an input as there is a wide range of cryogenic efficiencies. From 13% to 40% according to the strobridge curve and manufacturers literature.

Change this line in plant_power.f90 so it gives the input efficiency regardless of the type of magnet HTS or CRYO AL. This is misleading as it is always displayed regardless of the choice of magnet material/type.
call ovarre(outfile,'Efficiency (figure of merit) of cryogenic plant is 13% of ideal Carnot value:', &
'', (0.13D0*tmpcry)/(293.0D0 - tmpcry), 'OP ') with 0.13 replaced by eff_tf_cryo etc
@jonmaddock jonmaddock assigned jmorris-uk and unassigned cjwgriesel Oct 22, 2024
@jmorris-uk
Copy link
Contributor

jmorris-uk commented Jan 21, 2025 •
edited
Loading

Efficiency can already be input to a value between 0-1, if negative (-1) then it will default depending on superconducting material.

I've modified the output to correctly output 13%, 40% or user defined values for the efficiency.

@jmorris-uk jmorris-uk linked a pull request Jan 21, 2025 that will close this issue
1431 eff tf cryo needs to be an input but keeping the existing default values #3492
Open
6 tasks
@jmorris-uk jmorris-uk linked a pull request Jan 21, 2025 that will close this issue
Open
6 tasks
@mkovari
Copy link
Collaborator

mkovari commented Jan 21, 2025 •
edited
Loading

Why is this parameter described as "'TF coil cryo-plane efficiency'" in input.f90? All the coils need to be cryogenically cooled, not just the TF coils.

It would be much better to call it something like cryo_cop_ratio, to emphasise that it is not an efficiency, but a ratio of efficiencies (coefficients of performance).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmorris-uk jmorris-uk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1431 eff tf cryo needs to be an input but keeping the existing default values ukaea/PROCESS
4 participants
@mkovari @jmorris-uk @jonmaddock @cjwgriesel