Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Very low-resolution grids #1000

Closed
GeorgeGayno-NOAA opened this issue Nov 21, 2024 · 12 comments · Fixed by #1012
Closed

Very low-resolution grids #1000

GeorgeGayno-NOAA opened this issue Nov 21, 2024 · 12 comments · Fixed by #1012
Assignees
@GeorgeGayno-NOAA @LarissaReames-NOAA
Labels
maintenance Basic upkeep

Comments

@GeorgeGayno-NOAA
Copy link
Collaborator

GeorgeGayno-NOAA commented Nov 21, 2024 •
edited
Loading

The UFS group want to run the model at very low resolution - C24, C18 and C12.

Check if UFS_UTILS can create grids this coarse.

Add relevant unit tests.

Related issues:
#1004
ufs-community/ufs-weather-model#2508
@GeorgeGayno-NOAA GeorgeGayno-NOAA self-assigned this Nov 21, 2024
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Nov 21, 2024
@GeorgeGayno-NOAA
Update cpld_gridgen program to create C12, C18 and C24.
91c08f4 
Fixes ufs-community#1000.
@GeorgeGayno-NOAA
Copy link
Collaborator Author

Updated the cpld_gridgen program (91c08f4) to output C12, C18 and C24. The program ran to completion and a spot check of the files did not indicate any problems.

The files were placed on Hera: /scratch1/NCEPDEV/da/George.Gayno/ufs_utils.git/UFS_UTILS/fix/orog.lowres

@DeniseWorthen - can you take a quick look?

GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Nov 21, 2024
@GeorgeGayno-NOAA
Remove some unused logic from the orog program.
20d3b1e 
Fixes ufs-community#1000.
@DeniseWorthen
Copy link
Contributor

@GeorgeGayno-NOAA It seems to have generated the expected values.

I didn't check every combo, but I did some spot-checking. This for example is a "normal" c96.mx100 plot of land-frac

c96 mx100_landfrac

and this is C12.mx025

c12 mx025_landfrac

The land masses seem consistent, so I agree the generated files appear OK.

GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Nov 22, 2024
@GeorgeGayno-NOAA
Increase MAXSUM parameter so orog code will work with C12.
4612227 
Fixes ufs-community#1000.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Nov 22, 2024
@GeorgeGayno-NOAA
Update ocean merge script to point to location of low res
40a1c50 
'grid' files.

Fixes ufs-community#1000.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Nov 22, 2024
@GeorgeGayno-NOAA
Update gdas_init utility for low res cases.
53a97b8 
Fixes ufs-community#1000.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Nov 22, 2024
@GeorgeGayno-NOAA
Dynamically compute MAXSUM used in the computation of GWD
fe71fa1 
fields.

Fixes ufs-community#1000.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Nov 22, 2024
@GeorgeGayno-NOAA
Add strawman unit test for orog routine get_index.
73f9e7d 
Fixes ufs-community#1000.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Nov 25, 2024
@GeorgeGayno-NOAA
Add more test points to ftst_get_index.F90 unit test.
546153f 
Fixes ufs-community#1000.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Nov 25, 2024
@GeorgeGayno-NOAA
Add more test points to ftst_get_index.F90.
6936faa 
Fixes ufs-community#1000
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Nov 25, 2024
@GeorgeGayno-NOAA
Add some comments to unit test.
8ca9bdf 
Fixes ufs-community#1000.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Nov 26, 2024
@GeorgeGayno-NOAA
Merge branch 'develop' into lowres_grids
9d47f97 
Fixes ufs-community#1000.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Nov 26, 2024
@GeorgeGayno-NOAA
Baseline rough unit test for function inside_a_polygon.
c15de74 
Fixes ufs-community#1000.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Nov 26, 2024
@GeorgeGayno-NOAA
Add more test points.
35c06bd 
Fixes ufs-community#1000.
@GeorgeGayno-NOAA GeorgeGayno-NOAA mentioned this issue Dec 2, 2024
Open
@GeorgeGayno-NOAA GeorgeGayno-NOAA added the maintenance Basic upkeep label Dec 2, 2024
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 2, 2024
@GeorgeGayno-NOAA
Add point to test the case when the test point coincides with
cc477f4 
one of the polygon's corner points.

Fixes ufs-community#1000.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 2, 2024
@GeorgeGayno-NOAA
Add a test point located in the middle of the polygon.
cfe59e1 
Fixes ufs-community#1000.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 2, 2024
@GeorgeGayno-NOAA
Finish unit test for inside_a_polygon.
e8637db 
Fixes ufs-community#1000.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 3, 2024
Baseline a preliminary unit test for the two 'transpose' routines.
dc516b6 
Fixes ufs-community#1000.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 3, 2024
Update unit test to also call the transpose_orog routine.
1c21bcf 
Fixes ufs-community#1000.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 3, 2024
Add unit test for routine find_poles.
92bac68 
Fixes ufs-community#1000.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 3, 2024
Add partial unit test for routine find_nearest_pole_points.
58cd3bc 
Fixes ufs-community#1000.
@DeniseWorthen DeniseWorthen mentioned this issue Dec 4, 2024
Open
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 5, 2024
Complete unit test for "file_nearest_pole_points".
c8dad11 
Fixes ufs-community#1000.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Dec 9, 2024
Merge branch 'develop' into lowres_grids
db7f7c2 
Fixes ufs-community#1000.
@GeorgeGayno-NOAA
Copy link
Collaborator Author

The following grids were created and placed on Hera in /scratch1/NCEPDEV/da/George.Gayno/ufs_utils.git/UFS_UTILS/fix/orog.lowres

  • C12.mx900
  • C18.mx500
  • C24.mx500

GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Jan 10, 2025
@GeorgeGayno-NOAA
Baseline test for routine "qc_orog_by_ramp".
2dc24d6 
Fixes ufs-community#1000.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Jan 10, 2025
@GeorgeGayno-NOAA
Remove unneeded 'if' statement from 'qc_orog_by_ramp'.
92b232a 
Fixes ufs-community#1000.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Jan 10, 2025
@GeorgeGayno-NOAA
Update routine "write_mask_netcdf" to use f90 netcdf routines.
8a15fc3 
Fixes ufs-community#1000.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Jan 10, 2025
@GeorgeGayno-NOAA
Convert routine 'write_netcdf' to use f90 netcdf routines.
99a2e4f 
Fixes ufs-community#1000.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Jan 10, 2025
@GeorgeGayno-NOAA
Convert netcdf error routine to use f90 versions of netcdf.
1e57a0f 
Fixes ufs-community#1000.
@GeorgeGayno-NOAA
Copy link
Collaborator Author

@DeniseWorthen - to get cpld_gridgen to run at C12/18/24, I hardwired some changes at 91c08f4. Do you want to update the code more robustly for these resolutions?

GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Jan 13, 2025
@GeorgeGayno-NOAA
Remove some diagnostic print from the orog code.
6a68569 
Fixes ufs-community#1000.
@GeorgeGayno-NOAA GeorgeGayno-NOAA mentioned this issue Jan 13, 2025
Merged
6 tasks
@DeniseWorthen
Copy link
Contributor

Yes, Thanks. I'll update it to read a list of resolutions, now that the previous PR w/ the generalized resolutions is done.

GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Jan 13, 2025
@GeorgeGayno-NOAA
Revert cpld_gridgen changes. These will be handled by Denise.
8acb8a8 
Fixes ufs-community#1000.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Jan 13, 2025
@GeorgeGayno-NOAA
Minor cleanup to ./tests/orog/CMakeLists.txt.
a70379d 
Fixes ufs-community#1000.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Jan 13, 2025
@GeorgeGayno-NOAA
Add some comments to ./tests/orog/ftst_find_poles.F90.
bc2dac8 
Fixes ufs-community#1000.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Jan 13, 2025
@GeorgeGayno-NOAA
Update comments in ./tests/orog/ftst_get_index.F90.
9147bf3 
Fixes ufs-community#1000.
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Jan 13, 2025
@GeorgeGayno-NOAA
Fix print statement in ./tests/orog/ftst_get_xnsum3.F90
5f83189 
Fixes ufs-community#1000.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Jan 14, 2025
Update comments in ./tests/orog/ftst_qc_orog_by_ramp.F90
2197dff 
Fixes ufs-community#1000.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Jan 14, 2025
Fix typo in four tests.
97314f4 
Fixes ufs-community#1000.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Jan 14, 2025
Remove some unused variables from routine make_mask.
e90b3f3 
Fixes ufs-community#1000.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Jan 14, 2025
Remove temporary logic from ./ush/fv3gfs_ocean_merge.sh.
55d45fa 
Fixes ufs-community#1000.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Jan 14, 2025
Remove temporary logic from ./util/gdas_init/run_v16.chgres.sh.
28e0e0d 
Fixes ufs-community#1000.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Jan 14, 2025
Fix typo in ./util/gdas_init/run_v16.chgres.sh.
ac55299 
Fixes ufs-community#1000.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Jan 14, 2025
For gdas_init utility, set the default ocean resolution to
a074ec4 
9-degrees for the coarsest atmospheric resolutions.

Fixes ufs-community#1000.
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Jan 14, 2025
Revert ./util/gdas_init/config to original settings.
64d26a4 
Fixes ufs-community#1000.
@DeniseWorthen
Copy link
Contributor

@GeorgeGayno-NOAA I have a draft PR (#1013) for generation of the new low-res configurations on the ocean/ice side. But until the mosaic files are present in the fix directories, I still have some settings manually pointing to my own copy of the 'low res' directory.

For cpld_gridgen, the rt.conf has been modified to accept a list of resolutions, if present. Otherwise all available ATM resolutions will be used.

@GeorgeGayno-NOAA
Copy link
Collaborator Author

@GeorgeGayno-NOAA I have a draft PR (#1013) for generation of the new low-res configurations on the ocean/ice side. But until the mosaic files are present in the fix directories, I still have some settings manually pointing to my own copy of the 'low res' directory.

For cpld_gridgen, the rt.conf has been modified to accept a list of resolutions, if present. Otherwise all available ATM resolutions will be used.

I will open an issue to host the 'grid' and 'mosaic' files in the official 'fixed' directories.

@GeorgeGayno-NOAA GeorgeGayno-NOAA mentioned this issue Jan 16, 2025
Open
4 tasks
@GeorgeGayno-NOAA GeorgeGayno-NOAA changed the title Create very low resolution grids Very low-resolution grids Jan 17, 2025
GeorgeGayno-NOAA added a commit that referenced this issue Jan 17, 2025
@GeorgeGayno-NOAA
Update orography code for low-res grids (#1012)
d4f0db2 
Fix logic that caused crash for very low-resolution grids. Update I/O 
routines to use F90 NetCDF calls. Add unit tests for 20 subroutines/functions.

For complete details see #1000 and #1012.

Fixes #1000.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GeorgeGayno-NOAA GeorgeGayno-NOAA

@LarissaReames-NOAA LarissaReames-NOAA

Labels
maintenance Basic upkeep
Projects
Version 1.14.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update orography code for low-res grids GeorgeGayno-NOAA/UFS_UTILS
3 participants
@DeniseWorthen @GeorgeGayno-NOAA @LarissaReames-NOAA