Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure lint-staged hook correctly. #41

Closed
jordan-ae opened this issue Apr 25, 2024 · 5 comments
Closed

Configure lint-staged hook correctly. #41

jordan-ae opened this issue Apr 25, 2024 · 5 comments

Comments

@jordan-ae
Copy link
Contributor

          We have lint-staged for this purpose but perhaps it's not configured correctly.

Originally posted by @0x4007 in #40 (comment)

@gentlementlegen
Copy link
Member

@jordan-ae please provide a more in-depth description, and add a time estimate to it, thanks

@rndquu
Copy link
Member

rndquu commented May 28, 2024

@jordan-ae please provide a more in-depth description, and add a time estimate to it, thanks

As far as I understand this issue implies fixing running husky hooks (lint-staged in particular) on github commit.

So we need to:

  1. Make sure husky is setup on yarn install (here it should be postinstall)
  2. Make sure ts files are linted on commit

@jordan-ae
Copy link
Contributor Author

@gentlementlegen @rndquu this ticket might not need to exist. From my recent commits the lint-stage hook has been working correctly. We should close this as not planned.

@rndquu rndquu closed this as not planned Won't fix, can't repro, duplicate, stale May 28, 2024
Copy link

ubiquibot bot commented May 28, 2024

# Issue was not closed as completed. Skipping.

Copy link

[ 0.255 WXDAI ]

@gentlementlegen
Contributions Overview
View Contribution Count Reward
Issue Comment 1 0.255
Conversation Incentives
Comment Formatting Relevance Reward
@jordan-ae please provide a more in-depth description, and add a…
1.5
p:
  count: 15
  score: 1
0.17 0.255

[ 4.6 WXDAI ]

@rndquu
Contributions Overview
View Contribution Count Reward
Issue Comment 1 4.6
Conversation Incentives
Comment Formatting Relevance Reward
As far as I understand this issue implies fixing running husky h…
5
p:
  count: 45
  score: 1
code:
  count: 4
  score: 1
a:
  count: 1
  score: 1
0.92 4.6

[ 4.5 WXDAI ]

@jordan-ae
Contributions Overview
View Contribution Count Reward
Issue Specification 1 1.8
Issue Comment 1 2.7
Conversation Incentives
Comment Formatting Relevance Reward
We have lint-staged for this purpose but perhaps it's not config…
1.8
p:
  count: 18
  score: 1
em:
  count: 6
  score: 0
1 1.8
@gentlementlegen @rndquu this ticket might not need to exist. Fr…
5.4
p:
  count: 27
  score: 1
0.5 2.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants