Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assignment on editing github issue PR description #84

Closed
rndquu opened this issue Nov 15, 2024 · 11 comments · Fixed by #121
Closed

Fix assignment on editing github issue PR description #84

rndquu opened this issue Nov 15, 2024 · 11 comments · Fixed by #121

Comments

@rndquu
Copy link
Member

rndquu commented Nov 15, 2024

There's this issue which was initially assigned to Keyrxng.

What happened:

  1. I edited this PR comment
  2. ubiquity-os-beta suddenly assigned me to the issue while the expected behavior was to keep Keyrxng as the original assignee

P.S. Not sure what's the correct repository for this issue, https://github.com/ubiquity-os-marketplace/command-start-stop or https://github.com/ubiquity-os-marketplace/daemon-disqualifier

@0x4007
Copy link
Member

0x4007 commented Nov 18, 2024

Looks like the logic to capture the closing keywords also works on edits. I suppose that it should check if it is currently assigned, and if so, to not clobber assignment.

@Sadaf-A
Copy link

Sadaf-A commented Dec 24, 2024

/start

Copy link

Warning! This task was created over 38 days ago. Please confirm that this issue specification is accurate before starting.
Deadline Tue, Dec 24, 6:36 AM UTC
Beneficiary 0x0BEd00438D57d07E3667b85Fa8EB86Af147C7025

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@Sadaf-A
Copy link

Sadaf-A commented Dec 24, 2024

@rndquu @0x4007 So this issue belongs to the same repo right?

@rndquu
Copy link
Member Author

rndquu commented Dec 24, 2024

@0x4007
Copy link
Member

0x4007 commented Dec 25, 2024

@gentlementlegen i am guessing it's command start stop but would be great if you can confirm.

@gentlementlegen
Copy link
Member

Yes it is command-start-stop, the disqualifier never assigns users. I suppose this behavior has something to do with the flow on pull-request linking to assign users.

Copy link

Passed the disqualification threshold and no activity is detected, removing assignees: @Sadaf-A.

@gentlementlegen
Copy link
Member

I've investigated this, and this happens because there is logic associated to pull_request.edited. This was implemented because if you first open a PR without linking the issue, then edit your pull-request to add Resolves #-- we need to listen for this event to properly assign a user. I suppose the fix would be to assign the author of the pull-request instead of the user who edited it.

Copy link

Beneficiary 0x0fC1b909ba9265A846b82CF4CE352fc3e7EeB2ED

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link

ubiquity-os-beta bot commented Jan 14, 2025

 [ 52.46 WXDAI ] 

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueTask150
IssueComment22.46
ReviewComment10
Conversation Incentives
CommentFormattingRelevancePriorityReward
Yes it is `command-start-stop`, the disqualifier never a…
1.59
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 26
  wordValue: 0.1
  result: 1.59
0.810.32
I've investigated this, and this happens because there is [logic…
8.57
content:
  content:
    p:
      score: 0
      elementCount: 1
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 67
  wordValue: 0.1
  result: 3.57
112.14
Resolves #84QA:- [on editing a pull-request authored by a bo…
11.5
content:
  content:
    p:
      score: 0
      elementCount: 5
    ul:
      score: 0
      elementCount: 1
    li:
      score: 0.5
      elementCount: 3
    a:
      score: 5
      elementCount: 2
  result: 11.5
regex:
  wordCount: 35
  wordValue: 0
  result: 0
0.710

 [ 2.405 WXDAI ] 

@0x4007
Contributions Overview
ViewContributionCountReward
IssueComment22.405
Conversation Incentives
CommentFormattingRelevancePriorityReward
Looks like the logic to capture the closing keywords also works …
1.85
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 31
  wordValue: 0.1
  result: 1.85
111.85
@gentlementlegen i am guessing it's command start stop but would…
1.11
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 17
  wordValue: 0.1
  result: 1.11
0.510.555

 [ 28.82 WXDAI ] 

@rndquu
Contributions Overview
ViewContributionCountReward
IssueSpecification123.59
IssueComment15.23
Conversation Incentives
CommentFormattingRelevancePriorityReward
There's [this](https://github.com/ubiquity-os/ubiquity-os-plugin…
23.59
content:
  content:
    p:
      score: 0
      elementCount: 5
    ol:
      score: 0
      elementCount: 1
    li:
      score: 0.5
      elementCount: 2
    a:
      score: 5
      elementCount: 4
  result: 21
regex:
  wordCount: 46
  wordValue: 0.1
  result: 2.59
1123.59
I'm not 100% sure, https://github.com/ubiquity-os-marketplace/co…
10.46
content:
  content:
    p:
      score: 0
      elementCount: 1
    a:
      score: 5
      elementCount: 2
  result: 10
regex:
  wordCount: 6
  wordValue: 0.1
  result: 0.46
0.515.23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants