From 772eca55257f684a8cb18bc0317978e3786c2bb2 Mon Sep 17 00:00:00 2001 From: Tycho Andersen Date: Thu, 2 Jan 2025 13:39:16 -0700 Subject: [PATCH] Revert "ci: run more stuff in parallel" This reverts commit 02d2aec21b6ddc9076f6ff8329c53040c4c97a4e. I am seeing strange failures: 2025-01-02T20:34:18.7804797Z ##[group]Run make -j XCBDIR=./proto/src check 2025-01-02T20:34:18.7805365Z [36;1mmake -j XCBDIR=./proto/src check[0m 2025-01-02T20:34:18.7852242Z shell: /usr/bin/bash -e {0} 2025-01-02T20:34:18.7852657Z env: 2025-01-02T20:34:18.7853080Z pythonLocation: /opt/hostedtoolcache/Python/3.13.1/x64 2025-01-02T20:34:18.7853997Z PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.13.1/x64/lib/pkgconfig 2025-01-02T20:34:18.7854718Z Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.13.1/x64 2025-01-02T20:34:18.7855356Z Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.13.1/x64 2025-01-02T20:34:18.7855991Z Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.13.1/x64 2025-01-02T20:34:18.7856663Z LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.13.1/x64/lib 2025-01-02T20:34:18.7857186Z ##[endgroup] 2025-01-02T20:34:19.0988675Z flock xcffib.cabal cabal --config-file=./cabal.config new-run --minimize-conflict-set -j4 exe:xcffibgen -- --input ./proto/src --output ./xcffib 2025-01-02T20:34:19.1158356Z flock xcffib.cabal cabal --config-file=./cabal.config new-test -j4 --enable-tests 2025-01-02T20:34:19.1162762Z # the python in ATH in CI is the python from the matrix, so it is the 2025-01-02T20:34:19.1171432Z # "right" python to start with 2025-01-02T20:34:19.1178497Z python3 -m venv xcffib_venv 2025-01-02T20:34:19.1249266Z Warning: Both /home/runner/.cabal and /home/runner/.config/cabal/config exist 2025-01-02T20:34:19.1249706Z - ignoring the former. 2025-01-02T20:34:19.1250062Z It is advisable to remove one of them. In that case, we will use the remaining 2025-01-02T20:34:19.1250489Z one by default (unless '$CABAL_DIR' is explicitly set). 2025-01-02T20:34:19.6802799Z Warning: The package list for 'hackage.haskell.org' does not exist. Run 'cabal 2025-01-02T20:34:19.6803760Z update' to download it. 2025-01-02T20:34:19.6951914Z Resolving dependencies... 2025-01-02T20:34:19.6958135Z Error: [Cabal-7107] 2025-01-02T20:34:19.6958565Z Could not resolve dependencies: 2025-01-02T20:34:19.6959032Z [__0] trying: xcffib-1.6.0 (user goal) 2025-01-02T20:34:19.6959619Z [__1] unknown package: optparse-applicative (dependency of xcffib) 2025-01-02T20:34:19.6960341Z [__1] fail (backjumping, conflict set: optparse-applicative, xcffib) 2025-01-02T20:34:19.6961443Z After searching the rest of the dependency tree exhaustively, these were the goals I've had most trouble fulfilling: xcffib, optparse-applicative 2025-01-02T20:34:19.6962255Z 2025-01-02T20:34:19.6991946Z make: *** [Makefile:19: xcffib] Error 1 2025-01-02T20:34:19.6992444Z make: *** Waiting for unfinished jobs.... 2025-01-02T20:34:19.8783165Z Warning: The package list for 'hackage.haskell.org' does not exist. Run 'cabal 2025-01-02T20:34:19.8784979Z update' to download it. 2025-01-02T20:34:19.8868635Z Resolving dependencies... 2025-01-02T20:34:19.8873272Z Error: [Cabal-7107] 2025-01-02T20:34:19.8877165Z Could not resolve dependencies: 2025-01-02T20:34:19.8878003Z [__0] trying: xcffib-1.6.0 (user goal) 2025-01-02T20:34:19.8879629Z [__1] unknown package: optparse-applicative (dependency of xcffib) 2025-01-02T20:34:19.8880620Z [__1] fail (backjumping, conflict set: optparse-applicative, xcffib) 2025-01-02T20:34:19.8882116Z After searching the rest of the dependency tree exhaustively, these were the goals I've had most trouble fulfilling: xcffib, optparse-applicative 2025-01-02T20:34:19.8883618Z 2025-01-02T20:34:19.8906014Z make: *** [Makefile:62: htests] Error 1 2025-01-02T20:34:22.1161795Z xcffib_venv/bin/python3 -m pip install -r requirements.txt 2025-01-02T20:34:22.8676733Z Collecting flake8 (from -r requirements.txt (line 1)) 2025-01-02T20:34:22.9167437Z Downloading flake8-7.1.1-py2.py3-none-any.whl.metadata (3.8 kB) 2025-01-02T20:34:22.9387617Z Collecting autopep8 (from -r requirements.txt (line 2)) 2025-01-02T20:34:22.9440063Z Downloading autopep8-2.3.1-py2.py3-none-any.whl.metadata (16 kB) 2025-01-02T20:34:23.0726483Z Collecting cffi>=0.8.2 (from -r requirements.txt (line 3)) 2025-01-02T20:34:23.0768147Z Downloading cffi-1.17.1-cp313-cp313-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (1.5 kB) 2025-01-02T20:34:23.1392569Z Collecting pytest (from -r requirements.txt (line 4)) 2025-01-02T20:34:23.1433521Z Downloading pytest-8.3.4-py3-none-any.whl.metadata (7.5 kB) 2025-01-02T20:34:23.1750284Z Collecting pytest-xdist (from -r requirements.txt (line 5)) 2025-01-02T20:34:23.1806274Z Downloading pytest_xdist-3.6.1-py3-none-any.whl.metadata (4.3 kB) 2025-01-02T20:34:23.2003140Z Collecting mccabe<0.8.0,>=0.7.0 (from flake8->-r requirements.txt (line 1)) 2025-01-02T20:34:23.2042833Z Downloading mccabe-0.7.0-py2.py3-none-any.whl.metadata (5.0 kB) 2025-01-02T20:34:23.2230082Z Collecting pycodestyle<2.13.0,>=2.12.0 (from flake8->-r requirements.txt (line 1)) 2025-01-02T20:34:23.2267966Z Downloading pycodestyle-2.12.1-py2.py3-none-any.whl.metadata (4.5 kB) 2025-01-02T20:34:23.2445795Z Collecting pyflakes<3.3.0,>=3.2.0 (from flake8->-r requirements.txt (line 1)) 2025-01-02T20:34:23.2484735Z Downloading pyflakes-3.2.0-py2.py3-none-any.whl.metadata (3.5 kB) 2025-01-02T20:34:23.2610601Z Collecting pycparser (from cffi>=0.8.2->-r requirements.txt (line 3)) 2025-01-02T20:34:23.2647760Z Downloading pycparser-2.22-py3-none-any.whl.metadata (943 bytes) 2025-01-02T20:34:23.2755213Z Collecting iniconfig (from pytest->-r requirements.txt (line 4)) 2025-01-02T20:34:23.2797796Z Downloading iniconfig-2.0.0-py3-none-any.whl.metadata (2.6 kB) 2025-01-02T20:34:23.3048714Z Collecting packaging (from pytest->-r requirements.txt (line 4)) 2025-01-02T20:34:23.3092532Z Downloading packaging-24.2-py3-none-any.whl.metadata (3.2 kB) 2025-01-02T20:34:23.3291435Z Collecting pluggy<2,>=1.5 (from pytest->-r requirements.txt (line 4)) 2025-01-02T20:34:23.3340211Z Downloading pluggy-1.5.0-py3-none-any.whl.metadata (4.8 kB) 2025-01-02T20:34:23.3528800Z Collecting execnet>=2.1 (from pytest-xdist->-r requirements.txt (line 5)) 2025-01-02T20:34:23.3570921Z Downloading execnet-2.1.1-py3-none-any.whl.metadata (2.9 kB) 2025-01-02T20:34:23.3784619Z Downloading flake8-7.1.1-py2.py3-none-any.whl (57 kB) 2025-01-02T20:34:23.3859196Z Downloading autopep8-2.3.1-py2.py3-none-any.whl (45 kB) 2025-01-02T20:34:23.3962360Z Downloading cffi-1.17.1-cp313-cp313-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (479 kB) 2025-01-02T20:34:23.4074361Z Downloading pytest-8.3.4-py3-none-any.whl (343 kB) 2025-01-02T20:34:23.4150054Z Downloading pytest_xdist-3.6.1-py3-none-any.whl (46 kB) 2025-01-02T20:34:23.4211397Z Downloading execnet-2.1.1-py3-none-any.whl (40 kB) 2025-01-02T20:34:23.4273218Z Downloading mccabe-0.7.0-py2.py3-none-any.whl (7.3 kB) 2025-01-02T20:34:23.4333724Z Downloading pluggy-1.5.0-py3-none-any.whl (20 kB) 2025-01-02T20:34:23.4390715Z Downloading pycodestyle-2.12.1-py2.py3-none-any.whl (31 kB) 2025-01-02T20:34:23.4448683Z Downloading pyflakes-3.2.0-py2.py3-none-any.whl (62 kB) 2025-01-02T20:34:23.4506298Z Downloading iniconfig-2.0.0-py3-none-any.whl (5.9 kB) 2025-01-02T20:34:23.4569161Z Downloading packaging-24.2-py3-none-any.whl (65 kB) 2025-01-02T20:34:23.4630116Z Downloading pycparser-2.22-py3-none-any.whl (117 kB) 2025-01-02T20:34:23.4969723Z Installing collected packages: pyflakes, pycparser, pycodestyle, pluggy, packaging, mccabe, iniconfig, execnet, pytest, flake8, cffi, autopep8, pytest-xdist 2025-01-02T20:34:24.3293612Z Successfully installed autopep8-2.3.1 cffi-1.17.1 execnet-2.1.1 flake8-7.1.1 iniconfig-2.0.0 mccabe-0.7.0 packaging-24.2 pluggy-1.5.0 pycodestyle-2.12.1 pycparser-2.22 pyflakes-3.2.0 pytest-8.3.4 pytest-xdist-3.6.1 2025-01-02T20:34:24.5375638Z ##[error]Process completed with exit code 2. https://github.com/tych0/xcffib/actions/runs/12588389445/job/35086170982 which seem related to the parallelism. So let's drop this for now. --- .github/workflows/ci.yaml | 2 +- Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index b1597fc..e63f7b1 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -27,4 +27,4 @@ jobs: cabal-version: latest - run: sudo apt install x11-apps - run: git clone https://gitlab.freedesktop.org/xorg/proto/xcbproto.git proto && cd proto && git checkout ${{ matrix.xcbver }} - - run: make -j XCBDIR=./proto/src check + - run: make XCBDIR=./proto/src check diff --git a/Makefile b/Makefile index 60c98ba..1665e00 100644 --- a/Makefile +++ b/Makefile @@ -8,7 +8,7 @@ else endif NCPUS=$(shell grep -c processor /proc/cpuinfo) PARALLEL=$(shell which parallel) -CABAL=flock xcffib.cabal cabal --config-file=./cabal.config +CABAL=cabal --config-file=./cabal.config GEN=$(CABAL) new-run --minimize-conflict-set -j$(NCPUS) exe:xcffibgen -- VENV=xcffib_venv PYTHON=$(VENV)/bin/python3