-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rust platform #20
Comments
Resolves tsuru#20
Resolves tsuru#20
Resolves tsuru#20
Hello @scorphus. How's the current status of this? I think it's looking really nice, and I'd love to see Tsuru offering a default Rust platform. I believe if we remove the rust-docs, it could greatly reduce the base rust platform image size. Also, I believe it should be more strict with which toolchains are allowed, using the I'd like to know if you're still interested in finishing it, or do you want to pass ahead this issue. |
Hey, @jonnyguio! I'm glad this issue caught your attention! I tried to give it some traction by adding the hacktoberfest label two years ago, but nothing much happened. That's great, I'll be very happy seeing it solved! A lot has changed in Rust since then and I like your suggestions. I've updated the initial commit, mostly to remove the “WIP” part. So please feel free to work on top of it ‒ just please remember to keep it as is. What do you think if I open a pull request with the existing code and we both work on it ‒ code/review? |
Hey, @scorphus. Thanks for the quick reply! I'm really glad to hear that! I believe that opening the pull request is a great idea, so we can both work on it. You're right, a lot has change since two years ago, and the debut of the 2018 version is very close now. So, I think it's about time to address this issue. After seeing your code (and also do some myself), I started wondering about the following questions:
The last one is more about how to follow the default organization of Tsuru, to be consistent with the other languages (for example, the executable should be in What are your opinions? Feel free to answer it here or in the future PR. |
The text was updated successfully, but these errors were encountered: