Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device discovery crashes upon invalid device response #8

Open
seijikun opened this issue Apr 11, 2023 · 2 comments
Open

Device discovery crashes upon invalid device response #8

seijikun opened this issue Apr 11, 2023 · 2 comments

Comments

@seijikun
Copy link
Contributor

At the moment, device discovery seems to tightly expect devices to follow the standard.
Though I've seen stuff like:

  • Random sections of the xml missing
  • The device just responding with nothing (xml is just empty string)

At the moment, these things crash the application - mostly in unwrap() calls.
Would it be possible to have the library catch and ignore these cases?

@tsirysndr
Copy link
Owner

Can you give me some examples of xml that makes it crash?

@seijikun
Copy link
Contributor Author

The one I saw the most was literally an empty string. The location endpoint on the device just returned a body of 0 bytes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants