WordTree filter bug

[trivedigaurav]

"Therefore" is mentioned only in one of the documents but three are displayed in the grid (See screenshot). Can be an issue with the backend as well.

[trivedigaurav]

Backend is fine. Issue is in wordtree-layout.js

[trivedigaurav]

This bug is seen with left-most or right-most node in the tree that contain more than one word. Pending investigation.

[trivedigaurav]

1694335 fixes the issue by not allowing nodes to collapse if they have only one child. Fixes the bug but now the wordtree is more spread out. Can be made compact.

[trivedigaurav]

There are still some problems relating to this issue.

If I begin filtering from left and then switch to the right half, then there seems to be a problem.

[trivedigaurav]

The intersection computation logic in wordtree-controller lines 633-646 is flawed. For example, if I search for "with biopsy" and then filter on "with biopsy and", we also include documents that may contain "with biopsy" and "biospy and" but in different sentences. Not sure if we can resolve this just from the front end.

[trivedigaurav]

This needs to be fixed before the studies...

[trivedigaurav]

I am trying a fix at c390bd1. Needs to be tested properly.

[trivedigaurav]

I have merged the change with master at 8d066a3. But I am scared to close the bug as it keeps coming back :D. Hopefully, this time it has been fixed for good.

[trivedigaurav]

More issues found in the prepilot! Re-opening!!

[trivedigaurav]

The pre-pilot bug has been fixed with e07b376. I was expecting a set of sentences in lowercase from the backend but it wasn't the case. Converting to lowercase before matching in filters.