fix fading issues #4492
Merged
fix fading issues #4492
+72
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TychoVrahe
force-pushed
the
tychovrahe/bootloader/slow_fade_fix
branch
3 times, most recently
from
500ecf5 to
525a891
Compare
matejcik
requested changes
Jan 13, 2025
cepetr
approved these changes
Jan 13, 2025
matejcik
approved these changes
Jan 23, 2025
TychoVrahe
force-pushed
the
tychovrahe/bootloader/slow_fade_fix
branch
from
1c7bde1 to
a4a5f4c
Compare
TychoVrahe
force-pushed
the
tychovrahe/bootloader/slow_fade_fix
branch
from
a4a5f4c to
5f79785
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4392 fixes #4465
The slow fade in bootloader was due to function raising backlight was taking too long, waiting for display TE signal each time. Waiting for TE is removed as its no longer needed due to different mechanism using pending update - so now we will normally wait only once, after the display content is changed. In addition, the backlight fading function is rewritten to ensure constant fading time, at the possible expense of smoothness.
To mitigate the residual image issue, additional wait cycle is added when raising backlight.
As part of this fix i did i minor refactor, fading from python is now done by calling rust functions. The behavior of the fade is unified, so fading from python will behave a bit differently
Additional problem with fading is done before display refresh in progress layouts is fixed.