Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API improvements #63

Open
woodruffw opened this issue Oct 11, 2024 · 0 comments
Open

API improvements #63

woodruffw opened this issue Oct 11, 2024 · 0 comments
Assignees
@woodruffw

Comments

@woodruffw
Copy link
Member

woodruffw commented Oct 11, 2024 •
edited
Loading

There are a number of things we can do here to make these APIs more ergonomic:

  1. Remove all API-level foreign type dependencies: Attestation.verify should construct the sigstore types it needs internally, rather than having those foreign types passed in. remove Verifier param from verify() API #62
  2. Make Attestation.verify() take a Publisher instead of a VerificationPolicy, since the former can be transformed into the latter.
  3. Add some kind of Provenance.verify() API -- this needs a little more design thought.
@woodruffw woodruffw self-assigned this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@woodruffw woodruffw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@woodruffw