Welcome to Ember Contributing Guidelines. Follow these when you are thinking about contributing to Ember project. We welcome your contributions to Ember!
Here are the basic steps needed to get set up and contribute a patch.
- Install and set up Git.
- Fork the Ember repository to your GitHub account and get the source code using:
git clone --recursive https://github.com/<your_username>/Ember.git
cd Ember
-
Windows users can run the
GenerateProjects.bat
to generate project files.If you are getting errors, make sure you cloned the repo using
--recurse
option. If you are still getting errors (might because you are using an old git version), rungit submodule init
andgit submodule update
in the ember directory, and see if that resolves your issue, otherwise you can open an issue providing your git logs. -
Open the generated
Ember.sln
in Visual Studio. -
Create a new branch where your work for the issue will go, format it
fix-issue-#
, e.g.:git checkout -b fix-issue-12345 master
If an issue does not already exist, please create it. Trivial issues (e.g. typo fixes) do not require any issue to be created.
-
Once you fixed the issue, try building the solution, and check no errors are occuring, if everything is ok, commit.
-
Push the branch on your fork on GitHub and create a pull request. Include the issue number with format
Mentioned-Issue: ##
in the pull request description. For example:Mentioned-Issue: #12345: Fix x bug in y module
-
And you are done!