Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(parser): allow limit, offset to be used as both modifiers and aliases #4589

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Fix(parser): allow limit, offset to be used as both modifiers and aliases #4589

merged 1 commit into from
Jan 10, 2025
+38 −2

Conversation

georgesittas
Copy link
Collaborator

Fixes #4575

@georgesittas georgesittas force-pushed the jo/handle_modifiers_as_aliases_edge_Case branch from 95124e0 to a90a747 Compare January 9, 2025 20:45
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Benchmark for f61df65

Click to view benchmark
Test Base PR %
long 323.0±4.59µs 319.9±2.56µs -0.96%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Benchmark for 66a61e7

Click to view benchmark
Test Base PR %
long 317.5±4.40µs 317.1±6.19µs -0.13%

@georgesittas georgesittas force-pushed the jo/handle_modifiers_as_aliases_edge_Case branch from a90a747 to c4cb130 Compare January 9, 2025 20:50
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Benchmark for d37c8f3

Click to view benchmark
Test Base PR %
long 324.3±10.64µs 322.8±11.15µs -0.46%

@georgesittas georgesittas force-pushed the jo/handle_modifiers_as_aliases_edge_Case branch from c4cb130 to b7e117c Compare January 9, 2025 21:00
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Benchmark for e5b1b3a

Click to view benchmark
Test Base PR %
long 317.4±2.84µs 321.2±4.39µs +1.20%

@georgesittas georgesittas merged commit f3fcc10 into main Jan 10, 2025
8 checks passed
@georgesittas georgesittas deleted the jo/handle_modifiers_as_aliases_edge_Case branch January 10, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobymao tobymao Awaiting requested review from tobymao

@VaggelisD VaggelisD Awaiting requested review from VaggelisD

@geooo109 geooo109 Awaiting requested review from geooo109

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query with OFFSET statement without LIMIT in Trino get translated into invalid query in Snowflake
1 participant
@georgesittas