Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ping URL on success (feature request) #7

Open
Kalininator opened this issue Jan 1, 2022 · 3 comments · Fixed by #43
Open

Ping URL on success (feature request) #7

Kalininator opened this issue Jan 1, 2022 · 3 comments · Fixed by #43
Assignees
@tigattack
Labels
enhancement New feature or request

Comments

@Kalininator
Copy link

Would be good to have an option to ping a URL for success. Currently I have this bodged into the script manually.

Example usecase: ping endpoint for https://healthchecks.io on success, so will be alerted if you miss one. The on fail mention is pretty good but would not alert you if your script/job didn't run at all
@Kalininator Kalininator changed the title Ping URL on success Ping URL on success (feature request) Jan 1, 2022
@tigattack
Copy link
Owner

Great idea, cheers Kali. I'll work on this.

@tigattack tigattack added the enhancement New feature or request label Jan 5, 2022
@tigattack
Copy link
Owner

@Kalininator could you try the changes made in 44bafa6 and let me know what you think?
I've added some usage information too.

tigattack added a commit that referenced this issue Jan 6, 2022
@tigattack
fix(AlertSender): implement ping as specified #7
995c33c
@tigattack
Copy link
Owner

Sorry about that, I completely missed the point of this. Please give the changes in 995c33c a go and let me know how it goes. I've also updated the usage information to reflect the now correct functionality.

@tigattack tigattack mentioned this issue Jan 7, 2022
Open
tigattack added a commit that referenced this issue Mar 31, 2022
@tigattack
fix(AlertSender): implement ping as specified #7
880a261
@tigattack tigattack moved this to To do in VeeamNotify Mar 31, 2022
@tigattack tigattack moved this from To do to Waiting in VeeamNotify Mar 31, 2022
@tigattack tigattack self-assigned this Mar 31, 2022
@tigattack tigattack linked a pull request Jun 24, 2022 that will close this issue
Ping service implementation #43
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tigattack tigattack

Labels
enhancement New feature or request
Projects
VeeamNotify
Status: Waiting
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ping service implementation tigattack/VeeamNotify
2 participants
@tigattack @Kalininator