Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rlang type-checkers #77

Closed
hfrick opened this issue Oct 31, 2023 · 1 comment
Closed

Use rlang type-checkers #77

hfrick opened this issue Oct 31, 2023 · 1 comment
Labels
feature a feature request or enhancement

Comments

@hfrick
Copy link
Member

hfrick commented Oct 31, 2023

No description provided.

@hfrick hfrick added the feature a feature request or enhancement label Oct 31, 2023
@hfrick
Copy link
Member Author

hfrick commented Jul 27, 2024

There is no type checking done in poissonreg. We might add some in future but most of this engine code is run through parsnip which contains checks. Since this is largely a "use rlang type checkers instead of homegrown ones" issue, I'm gonna close. When we add type checks, we are (hopefully) automatically reaching for the rlang functions.

@hfrick hfrick closed this as completed Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hfrick