Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple Silicon compatibility #37

Open
jarmitage opened this issue Dec 6, 2022 · 8 comments
Open

Apple Silicon compatibility #37

jarmitage opened this issue Dec 6, 2022 · 8 comments

Comments

@jarmitage
Copy link

  • PyQt5 needs to be updated to PyQt6
  • QScintilla depends on PyQt5 and needs to be updated to PyQt6-QScintilla (https://pypi.org/project/PyQt6-QScintilla)
  • liblo, which underlies pyliblo, does not support Apple Silicon. Probably need to switch to python-osc or osc4py3
@jarmitage
Copy link
Author

As a workaround, is it possible to enable installing without OSC or a GUI?

This would also be useful anyway for using Vortex's Tidal parser in other Python projecs

@yaxu
Copy link
Member

yaxu commented Dec 6, 2022

Have you got a reference for liblo not supporting apple silicon? I don't think we'd want to move to a pure python library as that likely wouldn't work as well as liblo.
Happy to receive PRs for qt6 etc tho.

@jarmitage
Copy link
Author

jarmitage commented Dec 6, 2022

Ok, might be that liblo is fine, but having issues trying to install pyliblo3 on M1: gesellkammer/pyliblo3#2

@jarmitage
Copy link
Author

jarmitage commented Dec 6, 2022

Re Qt6, I can't test if it works yet, and wouldn't be able to test on Debian etc.

"In theory" it's just modifying pyproject.toml to:

PyQt6 = "^6.4.0"
PyQt6-QScintilla = "^2.13.3"

And then in gui.py:

from PyQt6.Qsci import *
from PyQt6.QtCore import *
from PyQt6.QtGui import *
from PyQt6.QtWidgets import *

So maybe if a Linux user can check that Qt6 doesn't break anything, then a PR might be possible.

@karstenj
Copy link
Collaborator

karstenj commented Feb 5, 2023

I checked the update to PyQt6 on a windows machine. I had to change a couple of lines in gui.py to get it running. Some symbolic constants have changed. @jarmitage could you get it running without these changes?

gui.patch

@karstenj
Copy link
Collaborator

karstenj commented Feb 6, 2023

Ich checked the change also in the github CI and it build also on Linux. I issued a pull request #38 for the change.

@karstenj
Copy link
Collaborator

karstenj commented Feb 8, 2023

@munshkr has merged the changes for PyQt6 to the main branch. @jarmitage could you check it? Maybe also to update the readme for MacOS.

@jarmitage
Copy link
Author

@karstenj I still cannot get this running on macOS due to the same issue with pyliblo3 on M1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants