-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mailto links should focus subject, not address #7618
Comments
We might not get to this anytime soon. But we'd welcome pull requests to implement the suggested behavior. |
It's possible to have a mailto URI without a recipient mailto:?subject=text. What should happen in such a case? Focus on the "To" field or the message body? |
Very valid point, focus should be on the first empty field of "To", "Subject" and body in that order. However this is a little more complex to implement as I currently understand it, as it seems with my (limited) understanding of the codebase that in So, there seems to me to be no direct way to access if any email address is going to be loaded into the "To" field from where the distribution of focus currently happens, but I might just be missing it. |
Thanks for looking into it. This feels too complicated address right now. So I merged your PR as is. We need to clean up the way recipients are handled anyway. That should make it easier to implement the desired focus logic afterwards. |
Actually I've looked into this again and how it is now, it causes a regression apart from the edge-case mailto link without a "to" address: When a user tries to share a file by K9, now the subject field is focused, while the "to" field is unfilled. This is I would say a valid use case. |
Thanks for staying on this. I'll revert the change, so we don't change the behavior when handling share intents. |
Revert "#7618 focus subject or content field on external intent"
Checklist
App version
6.603
Problem you are trying to solve
When opening a mailto link, I would expect to type the subject and body of the email. However, when K9 opens, the address field is focused, so finishing and sending the mail needs one unneccessary click.
example: mailto:[email protected]
Additionally, when I open a mailto link with the subject already filled, I would expect to type the body, but the address is focused.
example: mailto:[email protected]?subject=subject%20already%20filled
When replying to an email within K9, it directly focuses the body with the address and subject already filled. This is the behaviour I would expect also for mailto links.
Suggested solution
When opening an email from a mailto link, directly focus the subject if just the email address is given, and the body if the email address and subject is given.
Screenshots / Drawings / Technical details
No response
The text was updated successfully, but these errors were encountered: